Use rxdb from GitHub master in devDeps, npm version in peerDeps#392
Use rxdb from GitHub master in devDeps, npm version in peerDeps#392
Conversation
- package.json: peerDependencies.rxdb set to 17.1.0, devDependencies.rxdb set to github:pubkey/rxdb#<hash> - update-rxdb.yml: updates peerDeps version and devDeps commit hash - All CI workflows: build rxdb from source after npm install, remove node_modules from cache - extract-rxdb-version.sh and version.js: read from peerDependencies Agent-Logs-Url: https://github.com/pubkey/rxdb-server/sessions/b336d050-dc4d-457d-bf28-af2fec05b7c8 Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
|
@copilot rxdb build-from-source fails in the CI |
…from source When rxdb is installed from GitHub, npm strips the config/ directory (per rxdb's .npmignore), causing build:types to fail with TS5058. Added scripts/build-rxdb.sh that restores the missing config file before running the build. Agent-Logs-Url: https://github.com/pubkey/rxdb-server/sessions/7d9a4240-b8ba-444a-9883-6e19c3ff2e44 Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Fixed in 113a4a6. The issue was that rxdb's Added |
|
@copilot still fails: [0] > node ./scripts/update-version-variable.mjs |
build:types needs type declarations for rxdb's optional peer deps (react, angular, vue, firebase, mongodb, etc.) and @types/mocha. These aren't installed when rxdb comes from GitHub. Create stub declarations so the full build succeeds. Agent-Logs-Url: https://github.com/pubkey/rxdb-server/sessions/fdcf894a-1c1a-46ae-b876-f5d43cac6391 Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Fixed in 24fb3c4. The The updated
|
|
@copilot do not install these rxdb deps by your own list. Just install all dev-deps of the rxdb core inside of node_modules/rxdb |
Agent-Logs-Url: https://github.com/pubkey/rxdb-server/sessions/67bbfd26-f8db-4ffd-b609-a4d2db98fee9 Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
|
@copilot still fails: ./plugins/reactivity-vue |
… fix TS2742 Agent-Logs-Url: https://github.com/pubkey/rxdb-server/sessions/0b744627-14ce-4060-b488-fcacdbed7421 Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Fixed in 4b25fbe. The After install, the script now deduplicates by removing nested packages that already exist at root level with the same version. Verified locally — Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot instead of setting the repo url in the package.json, cant we just point to the tarball so it ignore the npmignore file when installing rxdb core? like: "dependencies": { |
…y build Agent-Logs-Url: https://github.com/pubkey/rxdb-server/sessions/afe90e55-8c75-49c1-a743-c8c9437be10a Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Fixed in e6458e3. Switched to the tarball URL format ( Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot ensure the inntegration memory tests work. Error atm:
transpiling.. (this takes some time on first run)Successfully compiled 1 file with Babel (267ms). transpiling DONE (4 CPUs)Exception during run: Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/runner/work/rxdb-server/rxdb-server/test-integration/node_modules/rxdb-server/node_modules/rxdb/dist/esm/plugins/utils/index.js' imported from /home/runner/work/rxdb-server/rxdb-server/test-integration/node_modules/rxdb-server/dist/esm/plugins/server/index.js |
…ests Agent-Logs-Url: https://github.com/pubkey/rxdb-server/sessions/427490ed-3684-416a-a43d-68daa06dcbe0 Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Fixed in b338c3c. The |
Local development and CI now track the latest rxdb master commit directly via GitHub tarball install, while the published peer dependency specifies the npm release version.
package.json
peerDependencies.rxdb:"*"→"17.1.0"(npm release version for consumers)devDependencies.rxdb:"17.1.0"→"https://github.com/pubkey/rxdb/archive/<commit-hash>.tar.gz"(latest master tarball for dev/CI — bypasses.npmignore, so all git-tracked files likeconfig/are included)update-rxdb.yml
peerDependencies.rxdbinstead ofdevDependencies.rxdbwith the highest npm versionpubkey/rxdbmaster viagit ls-remoteand writes the tarball URL todevDependencies.rxdbCI workflows (main.yml, build.yml, release.yml)
bash scripts/build-rxdb.shafternpm install— GitHub-installed packages don't shipdist/./node_modulesfromactions/cachepaths so the GitHub-installed rxdb is never served from stale cacheScripts
extract-rxdb-version.shandversion.jsnow read frompeerDependencies.rxdbinstead ofdevDependencies.rxdb, since devDeps is now a GitHub URLscripts/build-rxdb.shto handle building rxdb from source:npm installinsidenode_modules/rxdbto install all of rxdb's devDependenciesnode_modules/with the same version — prevents TypeScript from generating non-portable type paths likerxdb/node_modules/mingo/types(TS2742)npm run build