Add cursor pagination for list timelines#56
Open
RuochenLyu wants to merge 1 commit intopublic-clis:mainfrom
Open
Add cursor pagination for list timelines#56RuochenLyu wants to merge 1 commit intopublic-clis:mainfrom
RuochenLyu wants to merge 1 commit intopublic-clis:mainfrom
Conversation
jackwener
approved these changes
Apr 29, 2026
Collaborator
jackwener
left a comment
There was a problem hiding this comment.
Reviewed the list cursor pagination changes. No blocking findings. The implementation threads cursor/return_cursor through fetch_list_timeline, emits pagination.nextCursor for structured output, and has focused CLI/client tests. Local checks: ruff passed, mypy passed, new focused tests passed. Full pytest currently hits two pre-existing Rich table truncation assertions that also fail on main in this local env, so they are not introduced by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cursorsupport totwitter listpagination.nextCursorfor structured list timeline outputfetch_list_timelineThis follows the same shape as #49 for feed cursor pagination, reusing the existing timeline cursor extraction and structured pagination envelope.
Validation
uv run pytest -quv run mypy twitter_cliuv run ruff check .2049103846925029525: page 1 returned 5 tweets and a cursor; page 2 with that cursor returned 5 different tweets and a new cursor.