Skip to content

Fix lint filelist path #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smanoni merged 3 commits into from
Nov 20, 2025
Merged

Fix lint filelist path #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
949523b
Fix flist generation for slang lint
smanoni Nov 6, 2025
901f965
Avoid force on flist creation
smanoni Nov 7, 2025
03071a4
Fix Makefile with filelist generation with abs path
smanoni Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ slang:
stage: lint
script:
- make cp-slang-all
- (! grep -n "error:" sim/gen/elab.log)
- (! grep -n "error:" lint/elab.log)

artifacts:
name: "$CI_JOB_NAME-$CI_COMMIT_REF_NAME-$CI_COMMIT_SHORT_SHA"
Expand Down
19 changes: 18 additions & 1 deletion Bender.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,23 @@ sources:
- hw/pulp/control_pulp.sv
- hw/pulp/control_pulp_fpga.sv

- target: all(lint_pms)
files:
- hw/ips/tech_cells_generic/src/rtl/tc_sram.sv
- hw/ips/tech_cells_generic/src/rtl/tc_sram_impl.sv
- hw/ips/tech_cells_generic/src/rtl/tc_clk.sv
- hw/ips/tech_cells_generic/src/deprecated/cluster_pwr_cells.sv
- hw/ips/tech_cells_generic/src/deprecated/generic_memory.sv
- hw/ips/tech_cells_generic/src/deprecated/generic_rom.sv
- hw/ips/tech_cells_generic/src/deprecated/pad_functional.sv
- hw/ips/tech_cells_generic/src/deprecated/pulp_buffer.sv
- hw/ips/tech_cells_generic/src/deprecated/pulp_pwr_cells.sv
- hw/ips/tech_cells_generic/src/tc_pwr.sv
- hw/ips/tech_cells_generic/test/tb_tc_sram.sv
- hw/ips/tech_cells_generic/src/deprecated/pulp_clock_gating_async.sv
- hw/ips/tech_cells_generic/src/deprecated/cluster_clk_cells.sv
- hw/ips/tech_cells_generic/src/deprecated/pulp_clk_cells.sv

# TB sources
- target: any(test,simulation)
files:
Expand Down Expand Up @@ -133,7 +150,7 @@ sources:
- tb/vip/i2c_eeprom/24FC1025.v

# tech (gf22)
- target: gf22
- target: all(gf22, not(lint_pms))
files:
- nonfree/synth/gf22/sourcecode/tech_cells_gf22/pulp_power_gating.sv
- nonfree/synth/gf22/sourcecode/tech_cells_gf22/cluster_clock_inverter.sv
Expand Down
28 changes: 22 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ vcs-simc:
# Slang
#
SLANG ?= oseda slang
SLANG_DIR ?= $(ROOT_DIR)/sim/gen
SLANG_DIR ?= $(ROOT_DIR)/lint
SLANG_PARSE_LOG ?= $(SLANG_DIR)/parse.log
SLANG_LINT_LOG ?= $(SLANG_DIR)/lint.log
SLANG_ELAB_LOG ?= $(SLANG_DIR)/elab.log
Expand All @@ -279,21 +279,25 @@ SLANG_FLAGS := -f cp.flist --timescale=1ns/1ns --top pms_top
SLANG_FLAGS += -G SIM_STDOUT=0 -G USE_CLUSTER=1 -G CORE_TYPE=0 -G RISCY_FPU=1
SLANG_FLAGS += --relax-enum-conversions --allow-use-before-declare -Wno-error=duplicate-definition

BENDER_LINT_TARGETS += -t lint_pms

FORCE:

$(SV_FLIST): FORCE $(ROOT_DIR)/Bender.yml $(ROOT_DIR)/Bender.lock
$(BENDER) script flist-plus $(BENDER_BASE_TARGETS) -D SYNTHESIS > $@
$(SV_FLIST): $(ROOT_DIR)/Bender.yml $(ROOT_DIR)/Bender.lock
mkdir -p lint
$(BENDER) script flist-plus $(BENDER_LINT_TARGETS) $(BENDER_SYNTH_TARGETS) $(BENDER_BASE_TARGETS) -D SYNTHESIS > $@
sed -i 's?$(ROOT_DIR)?\$$CPROOT?g' $@

$(SLANG_PARSE_LOG): FORCE $(SV_FLIST)
@cd $(SLANG_DIR) && $(SLANG) $(SLANG_FLAGS) --parse-only 2>&1 | tee $@
@cd $(SLANG_DIR) && CPROOT=$(ROOT_DIR) $(SLANG) $(SLANG_FLAGS) --parse-only 2>&1 | tee $@
@echo "Slang parsing logged at: $@"

$(SLANG_LINT_LOG): FORCE $(SV_FLIST)
@cd $(SLANG_DIR) && $(SLANG) $(SLANG_FLAGS) --lint-only 2>&1 | tee $@
@cd $(SLANG_DIR) && CPROOT=$(ROOT_DIR) $(SLANG) $(SLANG_FLAGS) --lint-only 2>&1 | tee $@
@echo "Slang linting logged at: $@"

$(SLANG_ELAB_LOG): FORCE $(SV_FLIST)
@cd $(SLANG_DIR) && $(SLANG) $(SLANG_FLAGS) 2>&1 | tee $@
@cd $(SLANG_DIR) && CPROOT=$(ROOT_DIR) $(SLANG) $(SLANG_FLAGS) 2>&1 | tee $@
@echo "Slang elaboration logged at: $@"

## Generate Control Pulp .flist
Expand All @@ -311,6 +315,18 @@ cp-slang-elaborate: FORCE $(SLANG_ELAB_LOG)
## All
cp-slang-all: cp-slang-flist cp-slang-parse cp-slang-lint cp-slang-elaborate

#
# Spyglass
#
SNPS_SG ?= spyglass-2022.06

gen_sg_script:
mkdir -p spyglass/tmp
$(BENDER) script verilator $(BENDER_BASE_TARGETS) -D SYNTHESIS > lint/files

cp-sg-lint: gen_sg_script lint/func.sgdc lint/run_lint.tcl
cd lint; $(SNPS_SG) sg_shell -tcl run_lint.tcl

# DPI libraries
#

Expand Down