fix: Break combinational loop in desc64 speculation FIFO#91
Draft
DanielKellerM wants to merge 4 commits intomasterfrom
Draft
fix: Break combinational loop in desc64 speculation FIFO#91DanielKellerM wants to merge 4 commits intomasterfrom
DanielKellerM wants to merge 4 commits intomasterfrom
Conversation
Disable fall-through on i_speculation_fifo to break a combinational loop: flush -> staging_addr_valid_speculation -> speculation_valid -> speculation_correct -> flush. Under specific conditions this reduces to flush = !flush, a combinational oscillator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #71.
FALL_THROUGH=0) oni_speculation_fifoinidma_desc64_ar_gen_prefetchto break a combinational loop through the speculation check pathstaging_addr_valid_speculation→speculation_valid(fall-through) →speculation_check_addrmux →speculation_correct→flush→staging_addr_valid_speculationflush = !flush— a combinational oscillatorTest plan
tb_idma_desc64_top(558 descriptors, 0 errors)tb_idma_desc64_bench(1000 descriptors, 0 errors)