Add shared base types for Repositories, Publications, Remotes and Distributions - #307
Merged
Merged
Conversation
…pulpcore serializers
…based off serializer
…outside pulp core within common.ts
…cently updated serializer
…in confusion for ansible.
…n and publication types
Redtigercod4
force-pushed
the
feat/255-base-resource-types
branch
from
July 2, 2026 20:02
81288d7 to
8ccab40
Compare
Redtigercod4
changed the title
Redtigercod4
changed the title
Redtigercod4
marked this pull request as ready for review
July 2, 2026 20:20
5 tasks
Contributor
Author
|
@himdel Good advice on the previous PR, this one is smaller and more focused on base types against Pulp Core. I have now built out a fully typed & tested RPM Repository Client on the API layer but is now blocked by this one. There is an issue tracking all this work under #309 Would it be possible to get a review on this one so that I can fully raise the others? Blocked PRs: |
This was referenced Aug 18, 2026
Collaborator
|
Closing and reopening to get CI re-run after all the dependdency-updates |
Redtigercod4
added a commit
to Redtigercod4/pulp-ui
that referenced
this pull request
Sep 2, 2026
…tributions (pulp#307) * Added new common.ts within API folder to store generic types against pulpcore serializers * Updated types within common.ts and created a new RPM Repository type based off serializer * Updated ansible repository to new interface, mapped out shared types outside pulp core within common.ts * Updated file repository to new interface adding in new fields from recently updated serializer * Fixed issue with Ansible types. Removed incorrect comment due to plugin confusion for ansible. * Defined new distribution generic from pulpcore and built out ansible distribution * Defined new distribution and publication generic for file distribution and publication types * Defined new Remote generic and updated ansible remote type * Updated File Remote definition along with commit pinning references. * Updated Container distributions to have new interface against plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added shared base types in new
src/api/common.ts, mapped against Pulp's coreserializer types (repository, remote, distribution, publication). Types only —
no behavioural or structural changes to existing API calls.
Changes
src/api/common.tswithGenericResource,GenericRepository,GenericRemote,GenericDistribution,GenericPublicationand sharedplugin types.
types, correcting several field type mismatches.
Related
Sources