Skip to content

Mark distribution update/delete as non-immediate#2444

Merged
mdellweg merged 1 commit intopulp:mainfrom
pedro-psb:mark-dist-updates-as-non-immediate
Mar 5, 2026
Merged

Mark distribution update/delete as non-immediate#2444
mdellweg merged 1 commit intopulp:mainfrom
pedro-psb:mark-dist-updates-as-non-immediate

Conversation

@pedro-psb
Copy link
Copy Markdown
Member

@pedro-psb pedro-psb commented Mar 4, 2026 •
edited
Loading

AnsibleDistribution lifecycle hooks trigger heavy index rebuilds, so update and delete should not be dispatched with immediate=True. Pulpcore exposes the control of whether this can be run immediately via ALLOW_NON_BLOCKING_UPDATE and ALLOW_NON_BLOCKING_DELETE.

Fixes #2445

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

@pedro-psb pedro-psb force-pushed the mark-dist-updates-as-non-immediate branch from 86aa50b to cf3310b Compare March 4, 2026 19:29
@pedro-psb
Mark distribution update/delete as non-immediate
12b54d5 
AnsibleDistribution lifecycle hooks trigger heavy index rebuilds via
_update_index(), so update and delete should not be dispatched with
immediate=True. Set ALLOW_NON_BLOCKING_UPDATE and ALLOW_NON_BLOCKING_DELETE
to False on AnsibleDistributionViewSet.

Fixes pulp#2445
@pedro-psb pedro-psb force-pushed the mark-dist-updates-as-non-immediate branch from cf3310b to 12b54d5 Compare March 4, 2026 19:36
mdellweg
mdellweg approved these changes Mar 5, 2026
View reviewed changes
Comment thread pulp_ansible/app/viewsets.py
Comment on lines +1131 to +1132
ALLOW_NON_BLOCKING_UPDATE = False
ALLOW_NON_BLOCKING_DELETE = False
Copy link
Copy Markdown
Member

@mdellweg mdellweg Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As if we anticipated this...

@mdellweg mdellweg merged commit 29bc71d into pulp:main Mar 5, 2026
13 checks passed
@patchback
Copy link
Copy Markdown

patchback Bot commented Mar 5, 2026 •
edited
Loading

Backport to 0.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.18/29bc71dbc78badeefeac12171bcc7d4c16c435d8/pr-2444

Backported as #2446

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback Bot mentioned this pull request Mar 5, 2026
Closed
4 tasks
@patchback
Copy link
Copy Markdown

patchback Bot commented Mar 5, 2026 •
edited
Loading

Backport to 0.21: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.21/29bc71dbc78badeefeac12171bcc7d4c16c435d8/pr-2444

Backported as #2447

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback Bot mentioned this pull request Mar 5, 2026
Merged
4 tasks
@patchback
Copy link
Copy Markdown

patchback Bot commented Mar 5, 2026 •
edited
Loading

Backport to 0.20: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.20/29bc71dbc78badeefeac12171bcc7d4c16c435d8/pr-2444

Backported as #2448

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback Bot mentioned this pull request Mar 5, 2026
Closed
4 tasks
@patchback
Copy link
Copy Markdown

patchback Bot commented Mar 5, 2026 •
edited
Loading

Backport to 0.22: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.22/29bc71dbc78badeefeac12171bcc7d4c16c435d8/pr-2444

Backported as #2449

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback Bot mentioned this pull request Mar 5, 2026
Merged
4 tasks
@patchback
Copy link
Copy Markdown

patchback Bot commented Mar 5, 2026 •
edited
Loading

Backport to 0.24: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.24/29bc71dbc78badeefeac12171bcc7d4c16c435d8/pr-2444

Backported as #2450

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented Mar 5, 2026 •
edited
Loading

Backport to 0.29: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.29/29bc71dbc78badeefeac12171bcc7d4c16c435d8/pr-2444

Backported as #2451

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback Bot mentioned this pull request Mar 5, 2026
Merged
4 tasks
@patchback
Copy link
Copy Markdown

patchback Bot commented Mar 5, 2026 •
edited
Loading

Backport to 0.25: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.25/29bc71dbc78badeefeac12171bcc7d4c16c435d8/pr-2444

Backported as #2452

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

This was referenced Mar 5, 2026
Merged
Merged
@patchback
Copy link
Copy Markdown

patchback Bot commented Mar 5, 2026 •
edited
Loading

Backport to 0.28: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.28/29bc71dbc78badeefeac12171bcc7d4c16c435d8/pr-2444

Backported as #2453

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback Bot mentioned this pull request Mar 5, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees

No one assigned

Labels

backport-0.21 backport-0.22 backport-0.24 backport-0.25 backport-0.28 backport-0.29 no-issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transient issue: updating a distribution causes a task timeout

2 participants

@pedro-psb @mdellweg