Fixed migration 0156 - #8057
Draft
mdellweg wants to merge 2 commits into
Draft
Conversation
mdellweg
force-pushed
the
fix_relpath
branch
from
September 3, 2026 19:44
bddd258 to
ebf7161
Compare
mdellweg
force-pushed
the
fix_relpath
branch
from
September 4, 2026 10:11
24330d0 to
89addfc
Compare
Member
Author
|
Needs to (Apparently i cannot request a change on my own pull request. arrrrrg!) |
Since some plugins actually don't care about the relative path of content_artifacts, they should be able to be null. This both fixes the existing migration to account for formally "" paths to now be represented as None (NULL) and ships a second migration that is idempotent on the current, corrected timeline, but drops the not null constraint on installations that successfully applied the original version of it.
mdellweg
force-pushed
the
fix_relpath
branch
from
September 4, 2026 12:18
89addfc to
47647d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some plugins actually don't care about the relative path of content_artifacts, they should be able to be null. This both fixes the existing migration to account for formally "" paths to now be represented as None (NULL) and ships a second migration that is idempotent on the current, corrected timeline, but drops the not null constraint on installations that successfully applied the original version of it.
📜 Checklist
See: Pull Request Walkthrough