extend file modules#235
Merged
mdellweg merged 1 commit intopulp:developfrom Apr 28, 2026
Merged
Conversation
Member
|
Thank you! I'd like to see these parameters appear in the tests... |
Contributor
Author
|
Tests added. |
Contributor
Author
|
@mdellweg is there anything else I should fix here? I see you're already working on fixing the CI. How soon we could merge and release that modules? |
Member
|
Can you squash and rebase the commits please? |
maciej-markowski
force-pushed
the
feature/extend-file-modules
branch
2 times, most recently
from
80dd81f to
987bc73
Compare
maciej-markowski
force-pushed
the
feature/extend-file-modules
branch
from
987bc73 to
0752ab3
Compare
Contributor
Author
|
Squashed, rebased, all tests are passing. @mdellweg if there are no further remarks, can we release that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File modules are lacking parameters: autopublish for repository module and repository for distribution module. I propose an extension.