feat(release): configurable release-status readiness — ready-when + coverage (REQ-240, #612)#641
Merged
Merged
Conversation
…+ coverage (REQ-240, #612) `rivet release status` treated only verified/accepted as release-ready, so a V-model/ASPICE project — which verifies via links, not a status flip — could never green the gate. Readiness is now configurable via rivet.yaml's `release:` block: - `ready-when: [<status>...]` extends the release-ready status set (e.g. a project whose lifecycle gates on an `approved` sign-off). - `require: coverage` ALSO counts an artifact ready when its V is closed — every validate coverage rule applicable to its type is satisfied — regardless of the status string. Purely additive: a verified/accepted/ready-when artifact still counts, so switching modes never makes a release LESS cuttable. ReleaseConfig{ready-when, require} on ProjectConfig; cmd_release_status folds both into the readiness predicate, computing coverage V-closure only in coverage mode. Defaults unchanged (status-only). Confirmed end-to-end on a minimal schema: an `approved` widget whose V is closed by a tracing part is not-cuttable by status, cuttable under `require: coverage`, and blocks again when the trace is removed. Regression test release_status_ready_when_and_coverage_modes covers all four states. This completes REQ-240 (the earlier ready-when-only slice was partial). Implements: REQ-240 Verifies: REQ-240 Refs: REQ-007 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📐 Rivet artifact delta
Graphgraph LR
REQ_240["REQ-240"]:::modified
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Modified
Posted by |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes REQ-240.
rivet release statusreadiness is now configurable viarivet.yaml'srelease:block, so a V-model/ASPICE project (which verifies via links, not a status flip) can green the gate.ready-whenextends the built-in verified/accepted set.require: coveragecounts an artifact ready when its V is closed — every validate coverage rule applicable to its type is satisfied — regardless of status. Purely additive: a verified/accepted/ready-when artifact still counts, so switching modes never makes a release less cuttable.Note
Supersedes the closed #624 (which delivered only the
ready-whenhalf on a now-stale branch). This is both halves, fresh on main, so REQ-240 is fully implemented + verified.Verification
Regression test
release_status_ready_when_and_coverage_modeson a minimal schema exercises all four states: status-mode blocksapproved;ready-when: [approved]→ cuttable;require: coverage+ V-closed → cuttable;require: coverage+ V-open → blocks. rivet-core lib 1160 + cli_commands 149 green; clippy--all-targetsclean.🤖 Generated with Claude Code