Skip to content

Fix mobile TOC accordion stuck open#19338

Open
jeffmerrick wants to merge 1 commit into
masterfrom
jeffmerrick/fix-mobile-toc-accordion
Open

Fix mobile TOC accordion stuck open#19338
jeffmerrick wants to merge 1 commit into
masterfrom
jeffmerrick/fix-mobile-toc-accordion

Conversation

@jeffmerrick
Copy link
Copy Markdown
Contributor

@jeffmerrick jeffmerrick commented May 22, 2026

Generated description of changes:

Proposed changes

The accordion-content div in the docs table-of-contents partial had a Tailwind .flex utility class that won out over the display: none rule from docs/_docs-main.scss (imported inside @layer components), preventing #accordion-table-of-contents from collapsing on mobile. Dropping the flex class lets the SCSS cascade control show/hide again.

The accordion-content div had a Tailwind .flex utility class that won
out over the display: none rule from docs/_docs-main.scss (imported
inside @layer components), preventing the accordion from collapsing
on mobile. Dropping the flex class lets the SCSS cascade control
show/hide again.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:infra PR touches workflows, scripts, infra, Makefile, or build config and removed review:triaging Claude Triage is currently classifying the PR labels May 22, 2026
@jeffmerrick jeffmerrick requested a review from cnunciato May 22, 2026 13:53
@jeffmerrick jeffmerrick enabled auto-merge (squash) May 22, 2026 13:54
@github-actions github-actions Bot added the review:in-progress Claude review is currently running label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pre-merge Review — Last updated 2026-05-22T13:54:28Z

Tip

Summary: Infra change to layouts/partials/docs/table-of-contents.html — removes the utility flex class from <div class="accordion-content"> so the SCSS in theme/src/scss/docs/_docs-main.scss (lines 737–748) can actually toggle the mobile "On this page" accordion via the :checked selector instead of being overridden by an always-on display: flex. The breakage this would block is a reader-experience regression on mobile (TOC stuck open, label.show / label.hide states inconsistent); cross-checked the diff against the controlling SCSS rules to confirm the fix targets the root cause. No content/claims/frontmatter touched, so the verification, frontmatter, editorial-balance, and code-execution passes were skipped.

Review confidence:

Dimension Level Notes
mechanics HIGH
infra-correctness HIGH Verified against theme/src/scss/docs/_docs-main.scss lines 737–748: default div.accordion-content { display: none; } with input:checked ~ div.accordion-content { display: flex; } — the inline flex utility class was defeating the collapsed state.
Investigation log
  • Cross-sibling reads: not run (not in a templated section)
  • External claim verification: not run (no claims in this diff)
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: not run (no frontmatter in diff)
  • Temporal-trigger sweep: not run (no trigger words)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 0

🔍 Verification trail

No verifiable claims extracted from this diff.

🚨 Outstanding in this PR

No outstanding findings in this PR.

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

No items resolved since the last review.

📜 Review history

  • 2026-05-22T13:54:28Z — One-line CSS class removal in table-of-contents.html; verified against controlling SCSS, no blockers. (4b1c4ef)

Need a re-review? Want to dispute a finding? Mention @claude and include #update-review.
(For ad-hoc questions or fixes, just @claude — no hashtag.)

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels May 22, 2026
@pulumi-bot
Copy link
Copy Markdown
Collaborator

@pulumi-bot
Copy link
Copy Markdown
Collaborator

Lighthouse Performance Report

Commit: 4b1c4ef | Metric definitions

Page Device Score FCP LCP TBT CLS SI
Homepage Mobile 🟡 53 2.8s 3.2s 2421ms 0.004 7.4s
Homepage Desktop 🟡 75 0.7s 1.6s 310ms 0.041 2.5s
Install Pulumi Mobile 🟡 53 5.2s 9.1s 298ms 0.025 7.4s
Install Pulumi Desktop 🟡 85 1.1s 1.7s 22ms 0.015 2.6s
AWS Get Started Mobile 🟡 55 6.6s 14.0s 216ms 0.000 6.6s
AWS Get Started Desktop 🟡 85 1.1s 1.8s 24ms 0.030 2.6s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:infra PR touches workflows, scripts, infra, Makefile, or build config review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants