Skip to content

Refresh the 404 page#19351

Open
jeffmerrick wants to merge 1 commit into
masterfrom
jeffmerrick/404-refresh
Open

Refresh the 404 page#19351
jeffmerrick wants to merge 1 commit into
masterfrom
jeffmerrick/404-refresh

Conversation

@jeffmerrick
Copy link
Copy Markdown
Contributor

@jeffmerrick jeffmerrick commented May 22, 2026

This doesn't have clouds like the old one so is a little different, but still fun I think!

Resolves: #19225


Generated description of changes:

Proposed changes

Replaces the animated SVG cloud/beam illustration on the 404 page with a randomized, cycling ASCII-art display rendered in Pulumi violet. Removes the legacy _404.scss styles, its main.scss import, and the nine unused SVG assets under static/images/docs/404/. New ASCII art lives in layouts/partials/404-art.html and is swapped in by a small inline script every 1.5s.

Replaces the animated SVG cloud/beam illustration with a randomized,
cycling ASCII art display rendered in Pulumi violet. Removes the
legacy _404.scss styles and unused SVG assets.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:infra PR touches workflows, scripts, infra, Makefile, or build config and removed review:triaging Claude Triage is currently classifying the PR labels May 22, 2026
@jeffmerrick jeffmerrick changed the title Refresh the 404 page with cycling ASCII art Refresh the 404 page May 22, 2026
@github-actions github-actions Bot added the review:in-progress Claude review is currently running label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pre-merge Review — Last updated 2026-05-22T16:51:28Z

Tip

Summary: Presentational refresh of the 404 page: layouts/404.html swaps the animated SVG cloud/beam illustration for a cycling ASCII-art display rendered in Pulumi violet, sourced from a new layouts/partials/404-art.html partial, and the legacy theme/src/scss/_404.scss plus unused SVG assets under static/images/docs/404/ are deleted. No docs prose, frontmatter, or factual claims are touched, so the kind of wrongness that would block a reader is a broken render path or an accessibility regression on the error-recovery surface itself — not factual error. Verification passes that ran: candidate-claim extraction (regex+LLM, 6 candidates — all SVG path data or ASCII-art glyphs, routed to verifiers and uniformly classified not-a-claim), Vale prose lint (no findings), Hugo build (skipped: template-only change, full build runs in build-and-deploy.yml), frontmatter sweep (no frontmatter in diff), cross-sibling fan-out (not in a templated section).

Review confidence:

Dimension Level Notes
mechanics HIGH
facts HIGH
Investigation log
  • Cross-sibling reads: not run (not in a templated section)
  • External claim verification: 0 of 6 claims verified (0 unverifiable, 0 contradicted) · 4 specialists (numerical, cross-reference, capability, framing); 0 cross-specialist corroborations · routed: 0 inline, 0 Pass 1, 0 Pass 2, 6 Pass 3 (verified 0, contradicted 0, unverifiable 6).
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: not run (no frontmatter in diff)
  • Temporal-trigger sweep: ran (recency words present in diff; spot-check in-review)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 0

🔍 Verification trail

6 claims extracted · 0 verified · 0 unverifiable · 0 contradicted
  • L7 in layouts/404.html "" → ➖ not-a-claim (evidence: The text is an SVG element attribute (xmlns="http://www.w3.org/2000/svg"), which is a standard XML namespace identifier used in SVG markup — not a hyperlink or a falsifiable factual assertion. It is a code/markup artifact, not a claim ab…; source: http://www.w3.org/2000/svg)
  • L8-19 in layouts/404.html "" → ➖ not-a-claim (evidence: The flagged text is an SVG path element (<path fill="var(--color-violet-400)" d="M10.62,16.71..."/>) embedded in a 404 HTML layout file. It contains numeric coordinate data as part of an SVG shape definition, not a falsifiable factual as…; source: layouts/404.html L8-19 (SVG path data in HTML template))
  • L858-860 in layouts/partials/404-art.html "x' 8888R 88888X 88888f x' 8888R" → ➖ not-a-claim (evidence: The "claim" is ASCII art text from a 404 error page partial template. The string "8888R", "88888X", "88888f" are decorative ASCII art characters, not numerical assertions or falsifiable facts — they are purely visual/artistic content in an…; source: regex match on layouts/partials/404-art.html L858-860)
  • L861 in layouts/partials/404-art.html "d8eeeee88888eer 48888X 88888 d8eeeee88888eer" → ➖ not-a-claim (evidence: The text "d8eeeee88888eer 48888X 88888 d8eeeee88888eer" is ASCII art content within a 404 error page partial template. It contains no falsifiable assertion — it is decorative character art, not a numerical or factual claim.; source: layouts/partials/404-art.html L861)
  • L862 in layouts/partials/404-art.html "8888R ?888X 8888' 8888R" → ➖ not-a-claim (evidence: The "claim" is a line of ASCII art from a 404 page partial template. The numbers "8888" and "888" are purely decorative characters forming a visual pattern, not numerical assertions about any quantity, price, limit, or measurable fact.; source: layouts/partials/404-art.html L862 — ASCII art content, not a falsifiable numerical claim)
  • L863 in layouts/partials/404-art.html "8888R '88X 88*` 8888R" → ➖ not-a-claim (evidence: The "claim" is a line of ASCII art from a 404 error page partial template. The string "8888R" and similar patterns are purely decorative ASCII art characters, not numerical assertions about any factual matter.; source: layouts/partials/404-art.html L863)

🚨 Outstanding in this PR

No outstanding findings in this PR.

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

No items resolved since the last review.

📜 Review history

  • 2026-05-22T16:51:28Z — Clean presentational refresh of the 404 page (SVG → cycling ASCII art); no factual claims, no Vale findings, no blockers. (200c69a)

Need a re-review? Want to dispute a finding? Mention @claude and include #update-review.
(For ad-hoc questions or fixes, just @claude — no hashtag.)

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels May 22, 2026
@pulumi-bot
Copy link
Copy Markdown
Collaborator

@pulumi-bot
Copy link
Copy Markdown
Collaborator

Lighthouse Performance Report

Commit: 200c69a | Metric definitions

Page Device Score FCP LCP TBT CLS SI
Homepage Mobile 🔴 30 5.7s 6.8s 2282ms 0.000 8.8s
Homepage Desktop 🟡 84 0.8s 1.1s 305ms 0.006 1.3s
Install Pulumi Mobile 🔴 35 5.2s 7.6s 294ms 0.378 7.7s
Install Pulumi Desktop 🟡 89 1.2s 1.8s 20ms 0.013 1.3s
AWS Get Started Mobile 🟡 52 5.0s 8.2s 274ms 0.081 7.6s
AWS Get Started Desktop 🟡 89 1.2s 1.9s 22ms 0.021 1.3s

@jeffmerrick jeffmerrick requested a review from cnunciato May 22, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:infra PR touches workflows, scripts, infra, Makefile, or build config review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refresh the 404 page

2 participants