(maint) trace docker transport run_cmd

[h0tw1r3]

while tracing uploading files with the docker transport, I noticed many of the docker commands being run were not trace logged.

[donoghuc]

Are you saying that the trace logging with upload_file

bolt/lib/bolt/transport/docker/connection.rb

Line 100 in ca25a6b

@logger.trace { "Uploading #{source} to #{destination}" }

is not working? I dont think we log run_command in the other transports in the connection class, was this a parity feature or something you wanted generally for all the transports?

[h0tw1r3]

Are you saying that the trace logging with upload_file

bolt/lib/bolt/transport/docker/connection.rb

Line 100 in ca25a6b

@logger.trace { "Uploading #{source} to #{destination}" }

is not working? I dont think we log run_command in the other transports in the connection class, was this a parity feature or something you wanted generally for all the transports?

The executed docker commands are being trace logged in all cases (that I can see) except the upload/download commands. Very helpful to see when tracing/reproducing issues and maintains consistency.

[h0tw1r3]

For reference, the reason this came up is because the underlying command docker cp does not work with tmpfs volumes. When I did a bolt run with trace logging, I could see all of the executed docker commands except these, which was confusing and lead me to understand why the upload was not showing up in the container.

I dont think we log run_command in the other transports in the connection class, was this a parity feature or something you wanted generally for all the transports?

While this PR is for parity, it would be wonderful if all transports logged exec calls.