Skip to content

(MODULES-11972) Always install libcurl dev headers in module_ci #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imaqsood wants to merge 2 commits into from
Closed

(MODULES-11972) Always install libcurl dev headers in module_ci #190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a650108
(MODULES-11972) Always install libcurl dev headers in module_ci
imaqsood Oct 14, 2026
9c102f9
(MODULES-11972) Correct the patron dependency chain in module_ci comm…
imaqsood Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/module_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
default: '3.2'
type: "string"
additional_packages:
description: "Space-separated list of OS packages to install on the runner (apt-get)"
description: "Space-separated list of extra OS packages to install on the runner (apt-get), in addition to libcurl4-openssl-dev"
required: false
default: ''
type: "string"
Expand Down Expand Up @@ -60,13 +60,17 @@ jobs:
persist-credentials: false

- name: "Install additional packages"
if: ${{ inputs.additional_packages != '' }}
if: runner.os == 'Linux'
# libcurl4-openssl-dev is always installed for the Ruby 4 lane: faraday-follow_redirects
# <= 0.4 requires ruby < 4, so bundler can't use puppet_forge 4.x-6.0.x there and falls
# back to r10k 3.x -> puppet_forge 3.2 -> faraday 1.x. faraday 1.x depends on its adapter
# gems, including faraday-patron -> patron, a native extension that needs libcurl headers.
# Refresh the package index first: the runner image's baked-in apt lists can lag
# behind the live archive, so installing straight away can 404 on a package whose
# exact cached version has since been superseded and evicted from the mirror pool.
run: |
sudo apt-get update
sudo apt-get install -y ${{ inputs.additional_packages }}
sudo apt-get install -y libcurl4-openssl-dev ${{ inputs.additional_packages }}

@skyamgarp skyamgarp Oct 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imaqsood , we have added this installation for individual modules too https://github.com/puppetlabs/puppetlabs-concat/pull/840/changes#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR19


- name: "Configure forge authentication"
env:
Expand Down Expand Up @@ -121,13 +125,17 @@ jobs:
persist-credentials: false

- name: "Install additional packages"
if: ${{ inputs.additional_packages != '' }}
if: runner.os == 'Linux'
# libcurl4-openssl-dev is always installed for the Ruby 4 lane: faraday-follow_redirects
# <= 0.4 requires ruby < 4, so bundler can't use puppet_forge 4.x-6.0.x there and falls
# back to r10k 3.x -> puppet_forge 3.2 -> faraday 1.x. faraday 1.x depends on its adapter
# gems, including faraday-patron -> patron, a native extension that needs libcurl headers.
# Refresh the package index first: the runner image's baked-in apt lists can lag
# behind the live archive, so installing straight away can 404 on a package whose
# exact cached version has since been superseded and evicted from the mirror pool.
run: |
sudo apt-get update
sudo apt-get install -y ${{ inputs.additional_packages }}
sudo apt-get install -y libcurl4-openssl-dev ${{ inputs.additional_packages }}

- name: "Configure forge authentication"
env:
Expand Down
Loading