This repository was archived by the owner on Aug 31, 2019. It is now read-only.
Fix syntax highlighting of class definition arguments#6
Open
rkiyanchuk wants to merge 2 commits intopuppetlabs:masterfrom
rkiyanchuk:patch-1
Open
Fix syntax highlighting of class definition arguments#6rkiyanchuk wants to merge 2 commits intopuppetlabs:masterfrom rkiyanchuk:patch-1
rkiyanchuk wants to merge 2 commits intopuppetlabs:masterfrom
rkiyanchuk:patch-1
Conversation
added 2 commits
March 4, 2015 17:48
The `puppetDefArguments` region incorrectly highlights arguments if they contain functions due to braces in those functions that make the region to end at the first such argument, not at the end of definitions. See the example below:
```
class profile::dao::aio (
$yum_baseurl = hiera('yum::baseurl'),
$yum_baseurl_deps = hiera('yum::baseurl_deps'),
# Comment here
$debug = hiera('debug', false),
) { ... }
```
Suggested changes handle situations with functions in class definition better and also highlight inline comments.
Previous version had a bug and affected further class definition in `{ ... }`
This one seems ok, but still ugly. If you know better way to overcome functions inside the class arguments declaration, please let me know.
|
Waiting for CLA signature by @zoresvit @zoresvit - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
Author
|
It took you guys a while to respond: 1.5 years actually. I believe the changes are trivial enough and do not need licensing, I'm not sure if they are actual 1.5 years later though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
puppetDefArgumentsregion incorrectly highlights arguments if they contain functions due to braces in those functions that make the region to end at the first such argument, not at the end of definitions. See the example below:Suggested changes handle situations with functions in class definition better and also highlight inline comments.
Please review and feel free to express any concerns, I'll do further improvement to address those.