Add Custom Headers To File Server#57
Open
frasermince wants to merge 3 commits intopurescript-hyper:masterfrom
Open
Add Custom Headers To File Server#57frasermince wants to merge 3 commits intopurescript-hyper:masterfrom
frasermince wants to merge 3 commits intopurescript-hyper:masterfrom
Conversation
Collaborator
|
Thanks for the PR! I have some things to consider:
What do you think? |
Collaborator
|
Oh, by the way, have a look at the Travis CI report. There's an example that fails to compile. You can compile them with |
Author
|
Okay that sounds reasonable. And by FilePath -> Stats -> Array do you mean the stats type from Node.FS.Stats? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a way to have custom headers on the FileServer in order to Gzip the contents. I created another parameter to do that. Let me know if this is something that seems like would make sense for this or if there is a better way to do this than another parameter.