Skip to content

fix(mobile): stop the landscape video rotation loop - #404

Merged
altaywtf merged 3 commits into
mainfrom
fix/rotation-loop
Oct 25, 2026
Merged

altaywtf merged 3 commits into
mainfrom
fix/rotation-loop

Conversation

@altaywtf

@altaywtf altaywtf commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Change

Landscape video on phones rotates once and plays.

Phone, landscape .mp4 Before After
Auto-rotate on Turns every ~0.7 s, stuck at 00:00 One turn, plays
Locked landscape, no rotation ~170 player rebuilds in 30 s, stuck at 00:00 One player, plays
Landscape shell List-detail, "Menu" button Bar, one pane
  • Cause: any switch into or out of the drawer layout rebuilt the NavHost and the player. Hiding the bars for video was enough. Movable content keeps it now.
  • Under 480 dp tall uses phone rules, as in DESIGN.md.

Captures: comment below.

Validation

  • Code changes: ./gradlew verify and ./gradlew :mobile:assembleProductionDebug :tv:assembleProductionDebug
  • Proof for each matching row of the AGENTS.md proof map

Unverified: emulator only; no physical device.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-25T16:34:08.532652Z 6bc961e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf

Copy link
Copy Markdown
Member Author

Emulator captures, phone 1080×2400 and tablet 1600×2560 at 320 dpi.

Before After
Video, auto-rotate on (30 s) 31 rotation changes in 60 samples 1 rotation, playing
Phone landscape shell
Locked landscape stuck at 00:00

After only: PiP , tablet list-detail .

@altaywtf

Copy link
Copy Markdown
Member Author

Landscape locked, default density, no rotation: 30 s after the player opened.

Before After
168 player inits, 00:00 no new player, 00:44

@altaywtf
altaywtf merged commit db674dd into main Oct 25, 2026
4 checks passed
@altaywtf
altaywtf deleted the fix/rotation-loop branch October 25, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant