Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: wrong repository ownership #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Closed: wrong repository ownership #77
Changes from all commits
cf51f2eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
PUTIO_CLI_WEB_APP_URLis overridden, the CLI accepts any absolute URL and prints a device-link URL on that origin, but this new prompt tells the human to enter shared-account credentials into the printed browser page without first verifying its host. A poisoned workspace environment or simple misconfiguration could therefore disclose the shared credentials to a non-put.io site; require verification of the expected trusted origin before credential entry.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user follows the
auth approveworkflow documented below, the supported invocation necessarily passes the device approval code as a positional argument (or in--json), so the blanket instruction not to put approval codes in commands directly contradicts the examples and makes that legitimate flow appear prohibited. Limit this warning to account credentials and vault details, or explain how approval codes should be handled safely in shell history.Useful? React with 👍 / 👎.