docs(android): reconcile native tier-2 contracts - #46
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
The Android TV continue-watching specimen reduces visual affordance/contrast (progress track and unfocused buttons blend into the dialog), and the Android phone/tablet navbar destination set is now inconsistent with other Tier‑2 Android preview cards.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Tier‑2 “native” documentation/spec previews to better match current Material 3 + Compose (phone/tablet) and Compose for TV (Android TV) color-role contracts, and reconciles several preview specimens with the updated contract.
Changes:
- Update Android TV preview cards to use Compose for TV role naming (
surfaceVariant,border,inverseSurface) instead ofsurfaceContainer*/outline. - Update Android (phone/tablet) specimens for the current NavigationBar indicator geometry (56×32dp) and revise example destinations.
- Expand
platforms/android/DESIGN.mdandsystem/preview/_android.csswith explicit phone/tablet vs TV color-role mappings and updated contract wording.
File summaries
| File | Description |
|---|---|
| system/preview/androidtv-s03-continue-watching.html | Updates the Continue Watching dialog specimen to reference surfaceVariant instead of surfaceContainer/surfaceContainerHighest. |
| system/preview/androidtv-s02-account.html | Updates Tier‑2 token role callouts to use inverseSurface / surfaceVariant semantics for TV. |
| system/preview/androidtv-s01-search.html | Updates TV role naming (surfaceVariant, border) and clarifies focused chip fill role. |
| system/preview/androidtv-s00-shell.html | Updates TV shell role callouts and aligns icon sizing + focus color role naming (inverseSurface). |
| system/preview/android-s00-shell.html | Revises phone/tablet Tier‑2 copy, nav indicator geometry, and example bottom-nav destinations. |
| system/preview/android-e02-navbar.html | Updates the NavigationBar specimen to the 56×32dp indicator geometry and updates example destinations. |
| system/preview/_android.css | Adds explicit phone/tablet vs TV role→token mapping documentation and updates some specimen geometry. |
| platforms/android/DESIGN.md | Expands the binding contract to separately document phone/tablet vs TV color schemes and updates adoption/contract language. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53666cb42f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 761f0c6020
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
The Android tier-2 cards were still grounded in the replaced React Native app and a stale pre-Expressive navigation metric. This reconciles the contract and specimens with the measured native Compose implementation while leaving font delivery and production launcher artwork open in #43.
Changed
SWF→file-codeand nativeputio-androidadoption without adding platform-native outputs hereVerification
pnpm verifyon6c619bbnpm pack --dry-run: 30 files / 750.3 kBgit diff --checkgpt-5.6-solhighslopguard: one remaining ownership contradiction found and fixed in761f0c66c619bb, answered with commit proof, and resolvedReview Notes
Screenshots for the initial visual guide changes:
Follow-up proof for
6c619bb:Android TV guide cards are dark-only; light and dark capture requests intentionally render the same locked surface
Package, deploy, or release impact: the static guide changes after merge; no token, package API, generated artifact, Kotlin, Android XML, or release configuration changes
Follow-up work: Android binding review: ground the Android cards in putio-android shipped source #43 remains open for embeddable font files/licensing and production launcher artwork; Android adapter adoption belongs in
putio-android