ci: run checks on rollout stack bases - #178
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The workflow change is minimal, matches the stated intent, and is validated by an explicit contract test that prevents accidental broadening of push CI.
Pull request overview
This PR updates the “Next CI” GitHub Actions workflow so pull requests targeting rollout stack base branches under next-rollout/** also trigger the Next CI checks, while keeping push-triggered CI restricted to next. It fits into the repo’s workflow-contract approach by pairing the workflow change with an explicit contract test update.
Changes:
- Expand
pull_request.branchesinci-next.ymlto includenext-rollout/**. - Add a workflow contract test asserting PR base filtering includes rollout branches while
push.branchesremains["next"].
File summaries
| File | Description |
|---|---|
.github/workflows/ci-next.yml |
Adds next-rollout/** to the pull request base branch filter without changing push triggers. |
scripts/legacy-delivery-workflows.test.ts |
Updates/renames the Next CI contract test to validate the new PR base branch filter and confirm push remains limited to next. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
nextor anext-rollout/**stack parent.next; no job, permission, runner, or delivery behavior changes.Reviewer Guide
.github/workflows/ci-next.yml, then the workflow contract test.Visual Aids
Validation
pnpm test— 12/12 on90959c0actionlint .github/workflows/ci-next.ymlon90959c0mise run verifyon implementation commit8e2550c00c5e4epassed Next CI after the pnpm 12 alignment90959c0against00c5e4eSanity Checks
next-rollout/runtime-seammatches the new filter.next.Benchmarks
Notes
nextrollout.HOLD_UNMERGED; do not merge or enable auto-merge.