chore: fold lint:package into verify, add PR/issue templates, compat aggregate job - #177
Merged
Merged
Conversation
CI ran lint:package as a separate step after verify, so local verify runs missed tarball metadata, public type, and ESM entrypoint checks. Chain it into the verify script and drop the duplicate CI step. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Compatibility result depends on all 5 matrix jobs, runs on if: always(), and fails when the matrix failed or was cancelled. Gives the matrix one stable check name that can later become a required status check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Summary/Verification/Notes PR template, bug and feature issue forms, and blank_issues_enabled: false, matching the house GitHub surface. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Start Here now links docs/API-COVERAGE.md and docs/MIGRATING_V11.md. New Teardown section lists the previously unlisted clean and secrets:clean scripts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR aligns local and CI verification by folding lint:package into the verify script, adds GitHub PR/issue templates to standardize contributions, and introduces an aggregate “Compatibility result” job to simplify required-status-check configuration for the compatibility matrix.
Changes:
- Update
verifyto runlint:package, and remove the now-duplicate standalone CI step. - Add a PR template and YAML issue forms (bug + feature) with blank issues disabled.
- Add a
Compatibility resultaggregate job that reports a single pass/fail status based on the compatibility matrix outcome.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Fold lint:package into verify to make local vp run verify match CI behavior. |
| AGENTS.md | Add Start Here links for API coverage + v11 migration docs, and document teardown commands. |
| .github/workflows/ci.yml | Remove redundant lint:package CI step and add an aggregate compatibility result job. |
| .github/pull_request_template.md | Add a standard PR template (Summary/Verification/Notes). |
| .github/ISSUE_TEMPLATE/feature_request.yml | Add a structured feature request issue form. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Add a structured bug report issue form. |
| .github/ISSUE_TEMPLATE/config.yml | Disable blank issues (blank_issues_enabled: false). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lint:package already starts with vp pack, so verify packed twice. Reorder verify to let lint:package own the pack step, and update TESTING, DISTRIBUTION, and CONTRIBUTING to stop describing lint:package as a separate CI step. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 20, 2026
altaywtf
added a commit
that referenced
this pull request
Aug 20, 2026
The webkit job on #177 was killed by the 30-minute job timeout after apt-get update hung fetching archive.ubuntu.com inside playwright install --with-deps; the kill reports the job as cancelled and fails the aggregate. A step-level cap surfaces a mirror stall in 10 minutes instead of consuming the whole job budget. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
altaywtf
added a commit
that referenced
this pull request
Aug 20, 2026
* ci: replace job-level concurrency with a run-level group Job-level concurrency groups cancel superseded runs piecemeal: each matrix job of the old run fails its own group, the aggregate reports failure instead of cancelled, and because matrix jobs only enter their groups after verify finishes, start order can invert across runs and an older run's late matrix job can cancel a newer run's in-progress job. A single workflow-level group cancels a superseded pull request run atomically and queues pushes to main without cancelling release runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: cap browser runtime install at 10 minutes The webkit job on #177 was killed by the 30-minute job timeout after apt-get update hung fetching archive.ubuntu.com inside playwright install --with-deps; the kill reports the job as cancelled and fails the aggregate. A step-level cap surfaces a mirror stall in 10 minutes instead of consuming the whole job budget. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 11.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lint:packageinto theverifyscript and drop the duplicate CI step — localvp run verifynow matches CI..github/pull_request_template.md(Summary/Verification/Notes) and YAML issue forms (bug + feature) withblank_issues_enabled: false.Compatibility resultaggregate job: needs all 5 compatibility matrix jobs, runs onif: always(), fails on matrixfailureorcancelled. Coordinator should add it as a required status check; this PR does not touch rulesets.clean,secrets:clean) and Start Here routes fordocs/API-COVERAGE.mdanddocs/MIGRATING_V11.md.Fixes #176
Verification
vp run verify— 9 tasks green includinglint:package(publint + attw), 24 test files, 143 tests, 98% statement coveragevp run test:live,vp run test:compat, single-target live commands):Notes
Compatibility resulttreats a skipped matrix (upstreamVerify SDKfailure) as pass;Verify SDKremains the gate for that path.