Skip to content

[Maint] Line ending normalization wrong in some files #2802

Description

@echedey-ls

Describe the bug
Some files have been committed without applying line normalization. That's extra noise in diffs when a [Linux] dev changes something on a [Windows] CR-LF file.

These files are1:

❯ rg -l '\r'
tests/iotools/test_solcast.py
pvlib/iotools/solcast.py
pvlib/iotools/bsrn.py
pvlib/data/sam-library-sandia-modules-2015-6-30.csv
pvlib/data/12839.tm2
tests/data/midc_raw_short_header_20191115.txt
tests/data/precise_iv_curves_parameter_sets2.csv
tests/data/precise_iv_curves_parameter_sets1.csv

To Reproduce
See diff of #2799.

Expected behavior
A clear diff.

Screenshots
NA.
Versions:

  • pvlib.__version__: latest as of 2026-07-02
    NA.

Additional context
I suggest to

  1. apply line normalization
  2. maybe add * text=auto to .gitattributes (I think that would make git core.crlf=auto default Windows clients to behave properly)
  3. maybe add this commit to .git-blame-ignore-revs in the (near) future

For reference: https://stackoverflow.com/questions/15641259/how-to-normalize-working-tree-line-endings-in-git

Footnotes

  1. https://stackoverflow.com/a/13643222 (this answer will only provide a valid result on linux)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions