Repository navigation
Remove pvlib.irradiance.SURFACE_ALBEDOS in favour of pvlib.albedo.SURFACE_ALBEDOS - #2890
Draft
echedey-ls wants to merge 1 commit into
Draft
echedey-ls wants to merge 1 commit into
echedey-ls wants to merge 1 commit into
Conversation
In favour of pvlib.albedo.SURFACE_ALBEDOS
echedey-ls
commented
Oct 7, 2026
| import pvlib # used to avoid dni name collision in complete_irradiance | ||
|
|
||
| from pvlib._deprecation import pvlibDeprecationWarning, deprecated | ||
| from pvlib._deprecation import deprecated |
Member
Author
There was a problem hiding this comment.
Let's remember to clean up this import if/when king is also removed.
echedey-ls
added
the
deprecation
Member
It is now created :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib licensefuck ai[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.Cleaning up the list of unscheduled removals at #2396. Can I have a v0.17.0 milestone created? Before I proceed with the remaining of the list.
I'm leaving the whatsnew entry closer to whenever the deadline comes closer to avoid merge conflicts.