Skip to content

fixes links and ordering on package structure intro page#541

Merged
tkoyama010 merged 3 commits intopyOpenSci:mainfrom
tomato-gits:fix-intro-links-#538
Jul 12, 2025
Merged

fixes links and ordering on package structure intro page#541
tkoyama010 merged 3 commits intopyOpenSci:mainfrom
tomato-gits:fix-intro-links-#538

Conversation

@tomato-gits
Copy link
Copy Markdown
Contributor

the links and numbering have been updated to match the card titles, fixes #538

it would be good for someone to review the actual order of topics in the cards, to make sure they are sensible

@tkoyama010 tkoyama010 requested a review from Copilot July 12, 2025 19:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the ordering and update links on the package structure intro page so the card numbers and destinations align with their topics.

  • Replaced the link for card 2 to point at the sdist/wheel distribution guide.
  • Renumbered cards 3–7 to match the updated sequence.
  • Updated the publish card link to the correct PyPI/Conda publishing doc.
Comments suppressed due to low confidence (1)

package-structure-code/intro.md:42

  • [nitpick] The title 'Learn about building your package' could be misleading now that this card links to the sdist/wheel distribution guide. Consider renaming it to something like 'Learn about package distribution files' for consistency.
:::{card} ✨ 2. Learn about building your package ✨

Copy link
Copy Markdown
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkoyama010 tkoyama010 merged commit 49e26d7 into pyOpenSci:main Jul 12, 2025
3 checks passed
@tkoyama010
Copy link
Copy Markdown
Member

@allcontributors please add @tomato-gits for doc

@allcontributors
Copy link
Copy Markdown
Contributor

@tkoyama010

I've put up a pull request to add @tomato-gits! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

fix: Links and numbering in package-structure-code/intro.md

4 participants