fix: avoid collisions in duplicate-name suffixes - #61
Open
henryiii wants to merge 1 commit into
Open
Conversation
Overloads get a `_N` suffix, but the suffixed name could match a real symbol with that name in the input. The generated header then declared the same identifier twice and did not compile. Skip suffixes that a real symbol or an earlier generated name already uses. Assisted-by: ClaudeCode:claude-fable-5
henryiii
marked this pull request as draft
August 6, 2026 18:18
henryiii
marked this pull request as ready for review
August 7, 2026 03:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Addresses finding 6 in #59.
write_headergives duplicate names a_Nsuffix, so overloadsfoo, foobecomefoo, foo_2. If the input also has a real symbol namedfoo_2, the generated header declaresmkd_doc_foo_2twice and does not compile. The counter now skips suffixes that a real symbol or an earlier generated name already uses.Adds a regression test with an overloaded
fooplus realfoo_2andfoo_3symbols.