feat!: default to -std=c++17 and pin clang<19 - #62
Draft
henryiii wants to merge 1 commit into
Draft
Conversation
The default C++ standard used when no -std= flag is given moves from c++11 to c++17, so modern headers parse correctly. An explicit -std= from the caller still wins. pyproject.toml now mirrors the clang<19 constraint that CI applied, so the CI test step no longer needs --with "clang<19". Assisted-by: ClaudeCode:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
This addresses the remaining modernization items from the review in #59.
Behavior change: when the caller gives no
-std=flag,read_argsnow defaults to-std=c++17instead of-std=c++11. Modern headers parse better with it. An explicit-std=from the caller still wins; a new unit test covers both cases.pyproject.tomlnow declaresclang<19, the same constraint CI applied by hand. Newer clang bindings do not match the libclang versions that are commonly installed. The CI test step can now drop the redundant--with "clang<19".