fix(cmake): make EXTRA_ARGS a multi-value argument - #65
Open
henryiii wants to merge 1 commit into
Open
Conversation
EXTRA_ARGS was a one-value keyword, so only the first token was kept and the rest was silently dropped. Also read the package version from pybind11_mkdoc/__init__.py instead of hardcoding it in cmake/CMakeLists.txt. Assisted-by: ClaudeCode:claude-fable-5
henryiii
marked this pull request as draft
August 6, 2026 18:18
henryiii
marked this pull request as ready for review
August 6, 2026 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Addresses finding 8 and the version duplication from #59.
EXTRA_ARGSin thepybind11_mkdocCMake function was a one-value keyword, so only the first token reached the command and the rest was silently dropped. It is now a multi-value argument, and each element is passed as its own argv entry.cmake/CMakeLists.txtno longer hardcodes the version. It reads__version__frompybind11_mkdoc/__init__.pyand keeps the numeric components only, becauseproject(VERSION)does not accept a dev suffix.The CMake test now passes two extra defines and the sample header has a second guarded method, so both arguments must take effect for the test to pass. The installed copy of the functions file under
pybind11_mkdoc/share/was regenerated.