Skip to content

Use onedir PyInstaller bundles for faster macOS launch #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Collinw24 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −7
Open

Use onedir PyInstaller bundles for faster macOS launch #2765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions dist_assets/mac/pyfa.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,28 @@ pyz = PYZ(a.pure, a.zipped_data,

exe = EXE(pyz,
a.scripts,
a.binaries,
a.zipfiles,
a.datas,
exclude_binaries=True,
name='pyfa',
debug=False,
strip=False,
upx=True,
runtime_tmpdir=None,
console=False ,
icon=icon,
contents_directory='app',
)

app = BUNDLE(
coll = COLLECT(
exe,
a.binaries,
a.zipfiles,
a.datas,
strip=False,
upx=True,
name='pyfa',
)

app = BUNDLE(
coll,
name='pyfa.app',
version=os.getenv('PYFA_VERSION'),
icon=icon,
Expand Down
2 changes: 1 addition & 1 deletion pyfa.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ if platform.system() == 'Darwin':
'CFBundleVersion': '1.2.3',
'CFBundleShortVersionString': '1.2.3',
}
app = BUNDLE(exe,
app = BUNDLE(coll,
name='pyfa.app',
icon=icon,
bundle_identifier=None,
Expand Down
2 changes: 1 addition & 1 deletion scripts/osx-package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ echo "Building distributive..."
python3 -m PyInstaller -y --clean dist_assets/mac/pyfa.spec
echo "Compressing distributive..."
cd dist
zip -r "pyfa-$PYFA_VERSION-mac.zip" pyfa.app
zip -yr "pyfa-$PYFA_VERSION-mac.zip" pyfa.app
md5 -r "pyfa-$PYFA_VERSION-mac.zip"