Skip to content

Some more minor leaks #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lazka merged 3 commits into from
Aug 7, 2026
Merged

Some more minor leaks #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9afcac4
_raster_source_release_func: fix missing result decref
lazka Aug 7, 2026
5e2e23b
surface_set_mime_data: decref the interned string
lazka Aug 7, 2026
4d1e73e
surface_get_mime_data: decref mime_intern
lazka Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cairo/pattern.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,7 @@ _raster_source_release_func (cairo_pattern_t *pattern,
result = NULL;
goto error;
}
Py_DECREF (result);

Py_DECREF (pysurface);
PyGILState_Release (gstate);
Expand Down
3 changes: 2 additions & 1 deletion cairo/surface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ surface_set_mime_data (PycairoSurface *o, PyObject *args) {
mime_intern = PyUnicode_InternFromString (mime_type);
surface_capsule = PyCapsule_New(o->surface, NULL, NULL);
view_capsule = PyCapsule_New(view, NULL, NULL);
user_data = Py_BuildValue("(NNOO)", surface_capsule, view_capsule, obj, mime_intern);
user_data = Py_BuildValue("(NNON)", surface_capsule, view_capsule, obj, mime_intern);
if (user_data == NULL) {
PyBuffer_Release (view);
PyMem_Free (view);
Expand Down Expand Up @@ -558,6 +558,7 @@ surface_get_mime_data (PycairoSurface *o, PyObject *args) {
mime_intern = PyUnicode_InternFromString (mime_type);
user_data = cairo_surface_get_user_data(
o->surface, (cairo_user_data_key_t *)mime_intern);
Py_DECREF(mime_intern);

if (user_data == NULL) {
/* In case the mime data wasn't set through the Python API just copy it */
Expand Down
Loading