Open
Conversation
jessegrabowski
force-pushed
the
more-mlx-linalg
branch
3 times, most recently
from
d091723 to
8cd68d6
Compare
Member
Author
|
|
jessegrabowski
force-pushed
the
more-mlx-linalg
branch
from
8cd68d6 to
6584f1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dispatches for:
Shockingly, MLX has no native function for calculating the determinant of a matrix. The best we can do is LU factorization -> diagonal -> log sum. I implemented that so we'd have something, rather than just erroring out uselessly.
Oh we could do better if we know the matrix is PSD, then we could do cholesky instead of LU which is a bit cheaper.