Open
Conversation
Member
|
the input mutation is not a concern in jax which never does Inplace by default. Your test isn't strong enough because the compare py and numba (or other backend) run minimal rewrites you need to pass the fully fledged mode as an argument or even simpler test with an already inplace set subtensor (pass inplace=true to the test) and then call the function again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have no coverage for this Op because it doesn't have an
nfunc_name. There was a concern that because numpy returns a view, we could end up with graph mutations that pytensor is not aware of. An example is:I added some checks for this specific case, it seems like everything works ok?