Numba: Speedup RV eval by casting float parameters to float64#2223
Merged
Conversation
ricardoV94
force-pushed
the
numba_rv_dtype_autocast
branch
from
6ffc6fd to
eb35888
Compare
ricardoV94
changed the title
jessegrabowski
approved these changes
Jun 15, 2026
jessegrabowski
left a comment
jessegrabowski
left a comment
Member
There was a problem hiding this comment.
would prefer a commentary cleanup pass before this goes in
ricardoV94
force-pushed
the
numba_rv_dtype_autocast
branch
from
eb35888 to
7a6610c
Compare
Member
Author
|
Cleanup done |
Member
|
I double approve then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was slowing us down, specially in conjunction with #1917
The MvNormal actually fails in float32, which I was intending to fix only in #2186
A bit more comment verbosity than I'd like, but nit-fine imo