Skip to content

Close the udp socket in close(), not just drop the reference #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 2 commits into from
Aug 27, 2026
+11 −0
Merged

Close the udp socket in close(), not just drop the reference #3011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74b5534
Close the udp socket in close(), not just drop the reference.
youdie006 Aug 27, 2026
ef4befd
Merge branch 'dev' into udp-close-releases-socket
janiversen Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pymodbus/client/udp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ def close(self):

:meta private:
"""
if self.socket:
self.socket.close()
self.socket = None

def send(self, request: bytes, addr: tuple | None = None) -> int:
Expand Down
9 changes: 9 additions & 0 deletions test/client/test_client_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@ def test_udp_client_is_socket_open(self):
client = ModbusUdpClient("127.0.0.1")
assert client.is_socket_open()

def test_udp_client_close_releases_socket(self):
"""Test the udp client close method releases the socket."""
client = ModbusUdpClient("127.0.0.1")
assert client.connect()
sock = client.socket
client.close()
assert sock.fileno() == -1
assert not client.connected

def test_udp_client_send(self):
"""Test the udp client send method."""
client = ModbusUdpClient("127.0.0.1")
Expand Down