pack: clamp flash-algo RAM to the device's RAM region#1976
Open
eakorolev wants to merge 1 commit into
Open
Conversation
A DFP may declare an <algorithm> RAMsize larger than the device's actual RAM.
eakorolev
force-pushed
the
clamp-flash-algo-ram
branch
from
812bd0b to
87e4c0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_select_flash_ram()uses the pack's<algorithm RAMsize>as-is. When a DFP declares it largerthan the device's RAM, the loader (laid out top-down) lands past physical RAM and flashing faults
before erase.
Caught on
SiliconLabs.GeckoPlatform_EFR32MG21_DFP/EFR32MG21A020F768(RAM0x10000, algoRAMsize=0x18000):Memory transfer fault (write) @ 0x20017cb0.Fix: clamp the algo RAM to the containing RAM region — same as the flash-range clamp in
_add_flash_subregions(). Addedtest_ram_select_explicit_clamped_to_region(fails without the fix).Related: #1767 (same class of problem, unfixed); #1468 works around it per-target for MAX32660.