Fix warnings when building the documentation.#201
Conversation
Fix the warning related to `--repository` option. Add sphinx to requirements-test. Run `make html` as part of travis CI. Closes pypa#189
Mariatta
changed the title
| - pip install --upgrade pytest | ||
| - pip install -r requirements-test.txt | ||
| - pip install --upgrade pip flit | ||
| - flit install --deps develop |
There was a problem hiding this comment.
Rather than installing flit from PyPI, let's use python3 -m flit to use the master copy of flit for this.
|
Hmm, why wouldn't |
From the logs it logs like it pulls |
|
Ah, I see. Do you think 1.1.post0 would make more sense? |
|
Hum, 1.2.dev ? I guess you can try here see if it fixes stuff and then we
can advise. Still strange it uses the pip-installed one... We should try to
figure out why.
Also it's just my guess, I may be wrong !
…On Thu, Aug 30, 2018, 12:07 Mariatta ***@***.***> wrote:
Ah, I see. Do you think 1.1.post0 would make more sense?
Or 1.2.dev0?
I think it should also be its own change, separate from this PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#201 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAUez9UzFl9BQBDhKMAy5IXaQgL4T3nLks5uWDf2gaJpZM4WO0Lk>
.
|
|
Thanks, tested on my machine, and bumping the release number fixed it. |
|
This is now passing on Travis Python v3.6 and 3.7. I don't know what the problem is with Python 3.5, 3.4. Will look into it later. |
|
It's and installation issue. |
|
All green on travis ! 🥇to @Mariatta ! Appveyor seem to have hit a random error. |
(and I'm not allowed to restart...) |
|
Thanks @Carreau. Yeah we've seen that strange error on appveyor before I was wondering we can move all dependencies from requirements-test into "test" extras in pyproject.toml, and not rely on requirements-test anymore. |
Mariatta
changed the title
| - python3 -m pip install codecov | ||
| script: | ||
| - py.test --cov=flit | ||
| - sphinx-build -b html -d _build/doctrees doc _build/html |
There was a problem hiding this comment.
If you're trying to verify that it builds without warnings, I think you need the -W flag to turn warnings into errors.
Also, could we do this inside an if so it only builds the docs on one version of Python?
|
I'm trying push flit forwards a bit. I've got the docs building without warnings now, with a slightly different approach. If you're still interested in this (or anyone else reading this), I'd still be interested in having a convenient way to check that the docs build without warnings. Now it would make sense to integrate that into the tox config. |
3 participants
Fix the warning related to
--repositoryoption.Add sphinx to requirements-test.
Run
make htmlas part of travis CI.Closes #189