Replace string nodeids with a structured NodeId internally - #14758

Open

nicoddemus wants to merge 35 commits into

pytest-dev:mainfrom

nicoddemus:refactor-node-ids

Commits on Aug 5, 2026

Replace string nodeids with a structured NodeId internally

nicoddemus
and
claude
committed
3f76aab
Add changelog entry for the NodeId refactor

nicoddemus
and
claude
committed
2b91f16
Turn nodeid string/NodeId conversion helpers into NodeId classmethods

nicoddemus
and
claude
committed
d48740a
Make NodeId._str a lazily-computed cached attribute

nicoddemus
and
claude
committed
b20da6e
Improve docs
nicoddemus
committed
8603cbd
Remove NodeId.fspath, redundant with NodeId.path

nicoddemus
and
claude
committed
9942f36
Assert the actual nodeid value in test_to_json_nodeid_wire_shape

nicoddemus
and
claude
committed
fa607c8
Split NodeId into NodeId (live collection) and OpaqueNodeId (external strings)

nicoddemus
and
claude
committed
543e4da
Fix docs build warnings from the NodeId/OpaqueNodeId refactor

nicoddemus
and
claude
committed
77d24ff
Split NodeId into CollectionNodeId/ItemNodeId along the Collector/Item boundary

nicoddemus
and
claude
committed
6005798
Cache the original string directly in OpaqueNodeId.parse()

nicoddemus
and
claude
committed
0be32e6
Add NodeId.to_opaque() and use OpaqueNodeId as LFPlugin/NFPlugin's sole lookup type

nicoddemus
and
claude
committed
161294c
Add @override to _build_str implementations, moving the shim to compat.py

nicoddemus
and
claude
committed
ffc3376
Rename NodeId.to_opaque to as_opaque, add OpaqueNodeId.as_opaque

nicoddemus
and
claude
committed
3d60aa0
Use an explicit match statement in coerce_node_id

nicoddemus
and
claude
committed
5f72ff8
Review changes
nicoddemus
committed
396982f
Move comment
nicoddemus
committed
e9bccc7
Rename _pytest._nodeid to _pytest.nodeid

nicoddemus
and
claude
committed
6950878
Fix stale CallSpec2 reference in ParamId docstring after rebase

nicoddemus
and
claude
committed
bb23f28
Fix grammar
nicoddemus
committed
de2b0e0
Use slots=True/kw_only=True on nodeid.py dataclasses

nicoddemus
and
claude
committed
b1e3e95
Doc changes
nicoddemus
committed
d495b3d
Remove cross-type equality between CollectionNodeId/ItemNodeId/OpaqueNodeId

nicoddemus
and
claude
committed
3ff11cd
Remove str support from Node.__init__'s nodeid parameter

nicoddemus
and
claude
committed
8277a2d
Add a runtime check that Node.__init__'s nodeid is a NodeId or None

nicoddemus
and
claude
committed
e580846
Remove Node.__hash__

nicoddemus
and
claude
committed
09acd5d
Fold _WithNodeId into BaseReport; use match in junitxml's node_reporter

nicoddemus
and
claude
committed
b6565f0
Replace remaining nodeid string-splitting with OpaqueNodeId.path/.rest

nicoddemus
and
claude
committed
481409d
Extend OpaqueNodeId to (path, names, params); convert mangle_test_address/matchreport

nicoddemus
and
claude
committed
2df09b9
Drop ParamId; merge OpaqueNodeId into ItemNodeId

nicoddemus
and
claude
committed
952e6ce
Collapse CollectionNodeId into a single NodeId class

nicoddemus
and
claude
committed
a2c2dbc
Remove stale type: ignore[misc] from test_nodes.py

nicoddemus
and
claude
committed
17aef40
Rename NodeId.leaf(name, params) -> child(name).with_params(params)

nicoddemus
and
claude
committed
599f551
Tighten Node.parent type to Collector | None

nicoddemus
and
claude
committed
a995cdb
Remove "Experimental/internal" notes from NodeId .id property docstrings

nicoddemus
and
claude
committed
4c4c6cc