Repository navigation
Conversation
max-moser
force-pushed
the
mm/pyproject-config
branch
from
July 7, 2026 14:34
65a5cdb to
ceb1f4b
Compare
max-moser
force-pushed
the
mm/pyproject-config
branch
from
July 11, 2026 08:47
ceb1f4b to
511f10d
Compare
akx
force-pushed
the
mm/pyproject-config
branch
from
October 30, 2026 09:11
511f10d to
da57261
Compare
akx
requested changes
Oct 30, 2026
akx
left a comment
Member
There was a problem hiding this comment.
This would require tests -- oh and what happens if this finds a pyproject.toml that doesn't have tool.babel?
Author
|
Thanks for the review, I'll spruce up the PR a bit. 🙂 |
max-moser
force-pushed
the
mm/pyproject-config
branch
from
October 30, 2026 10:46
da57261 to
a39395c
Compare
If present, use a "pyproject.toml" file for default configuration of `pybabel` commands.
max-moser
force-pushed
the
mm/pyproject-config
branch
from
October 30, 2026 11:07
a39395c to
af58d33
Compare
max-moser
commented
Oct 30, 2026
max-moser
left a comment
Author
There was a problem hiding this comment.
I've touched up the PR a bit to address your feedback (especially the case when the section is missing from pyproject.toml) and generally touched up the implementation a little bit (with type hints and such).
There's now a test case for the config parsing itself, and one for the extract_messages CLI command that basically emulates what another test did, but with the config coming from pyproject.toml instead of CLI args.
| if cmdname not in self.commands: | ||
| self.parser.error(f'unknown command "{cmdname}"') | ||
|
|
||
| # TODO add possibility to turn TOML config parsing off, e.g. new option above? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should close #777
This PR adds support of
pyproject.tomlas a source for default configuration values for the various CLI commands (compile,extract,init,update).The configuration will be read from
pyproject.toml, under the[tool.babel.<command_name>]table, where<command_name>is one ofcompile_catalog,extract_messages,init_catalog,update_catalog(taken fromfrontend_setuptools).The motivation for this PR here is that I've recently migrated most of the
inveniosoftwarepackages fromsetuptoolstohatchlingand we included the old configuration fromsetup.cfginpyproject.toml, only to find thatpybabeldoesn't actually read any command config frompyproject.toml😅(Luckily for us that was only a minor issue in one package that we fixed otherwise)
The mechanism for finding
pyproject.tomlis similar to that used in other tools, likeisort.I could also imagine adding a global CLI flag for disabling reading
pyproject.tomlaltogether, or for letting users specify another TOML config file instead.The parsed values are inserted as default values for the
optparseparser, so user-provided CLI flags should still take precedence.Please let me know if this goes in an acceptable direction, then I can polish up the implementation a bit 🙂