Repository navigation
Respect preformatted string numerators in compound-unit formatting - #1399
Open
nawaaaaaAaar wants to merge 1 commit into
Open
nawaaaaaAaar wants to merge 1 commit into
nawaaaaaAaar wants to merge 1 commit into
Conversation
akx
force-pushed
the
fix/preformatted-compound-numerator
branch
from
October 30, 2026 11:26
ce706dd to
745fc45
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1399 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 27 27
Lines 4939 4939
=======================================
Hits 4621 4621
Misses 318 318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1398.
The compound-unit fast path formats
"1 kg"plusnumerator_unit="kilometer"as"1 kg kilometer per hour", even though the documented string-value contract says to ignore the corresponding unit. This can corrupt display labels when a caller accepts either numeric quantities or already-localized strings alongside unit metadata.Exclude preformatted string numerators from that numeric fast path. The existing general path already handles them correctly; numeric inputs keep the existing optimization and formatting.
Reproduction and regression evidence
Unchanged upstream:
e2a17919f0eb988bfea2883b00793ca4d5d37c4f.The final 18 regression cases fail before the production change and pass afterward. They compare the explicitly documented ignored-unit behavior for two preformatted labels across English, Finnish and French, at all three display lengths.
Verification
scripts/download_import_cldr.py.pytest -q --doctest-modules babel/units.py tests/test_units.py: 53 passed.ruff check .andgit diff --check: passed.python -m build --no-isolation.Assistance and scope
Prepared with AI assistance for investigation, implementation and test execution. No personal review, provenance attestation or maintainer approval by the account owner is asserted. This is a focused behavioral correction, not a change to unit data or plural rules.
Combined verification
Tested together with the independent fractional-duration fix in #1401: 7,893 passed, seven skipped, two expected failures, with one existing pytest deprecation warning, on Python 3.12.13. Full Ruff checks pass. This combined test used a separate local worktree; this PR's branch and scope remain unchanged.