This repository was archived by the owner on Mar 31, 2020. It is now read-only.
Green Greenhouses#2
Open
FelixRandle wants to merge 50 commits intopython-discord:masterfrom
FelixRandle:master
Open
Green Greenhouses#2FelixRandle wants to merge 50 commits intopython-discord:masterfrom FelixRandle:master
FelixRandle wants to merge 50 commits intopython-discord:masterfrom
FelixRandle:master
Conversation
setup a basic frame and added the frame of the login page
-> Pulls calendar evetns from sqlite3 database -> Displays them with a small, basic tkinter GUI -> See the populate() function in DBHandler and add your events there. Next step is to add an "add event" GUI interface.
I'm a silly boy.
* Added basic backend functionality -> Pulls calendar evetns from sqlite3 database -> Displays them with a small, basic tkinter GUI -> See the populate() function in DBHandler and add your events there. Next step is to add an "add event" GUI interface. * Moved folder I'm a silly boy.
-> You can now add an event with a click of a button -> Simple GUI, needs improving -> Next task is to remove events
* Added basic backend functionality -> Pulls calendar evetns from sqlite3 database -> Displays them with a small, basic tkinter GUI -> See the populate() function in DBHandler and add your events there. Next step is to add an "add event" GUI interface. * Moved folder I'm a silly boy. * Added Add event option and menu -> You can now add an event with a click of a button -> Simple GUI, needs improving -> Next task is to remove events
Created a new file for each of the application's pages.
* Added basic backend functionality -> Pulls calendar evetns from sqlite3 database -> Displays them with a small, basic tkinter GUI -> See the populate() function in DBHandler and add your events there. Next step is to add an "add event" GUI interface. * Moved folder I'm a silly boy. * Added Add event option and menu -> You can now add an event with a click of a button -> Simple GUI, needs improving -> Next task is to remove events * Split up pages Created a new file for each of the application's pages.
Merged Zrupi UI with main file. Fixed errors with DBHandler addEvent call.
Moved some brackets.
-> Added a method to remove an event from the database - functional but needs to be hooked up to the UI which I hope is a WIP. -> Fixed some PEP-8 Gucciness.
-> Hooked up delete functionality to basic button and UI - It doesn't refresh, see discord. -> Fixed some PEP-8 violations -> Fixed wrong table name
…eck if all inputs have been filled
Gave application constant size.
Apparently I can't do merge conflicts lmao
Added new file: loginpage.py Added new methods: DBHandler.py: addUser() tryLogin() Still need to implelement what actually happens when the user logs in. IE a redirect to calendar.py. Basic UI has been built for the login system with message boxes and stuff, take a look.
added more indepth date checking and addedback button 😄
Updated path to reflect loading from different path
Dark mode added, currently toggled by pressing Q on any page.
* Update application.py added more indepth date checking and addedback button 😄 * fixed bug that alows you to have month be 0 * fixed linting and bug where month/day could be 0
* Update application.py added more indepth date checking and addedback button 😄 * fixed bug that alows you to have month be 0 * fixed linting and bug where month/day could be 0 * Update application.py changd inputs to tk.Text from tk.Entry and resized the entry boxes also when you create a event is updates the list * Update application.py added the start of horrible looks and the hatrid * updated __main__ and app.py this one is anoying all black, text is near black to click you have to hold left click when clicking a button a popup will apear press enter then let go of left click on the let go the button will click also closing the app may be hard * added more hatrid * removed random import * fixed linting issue
Undid things done poorly or already done previously.
* Update application.py added more indepth date checking and addedback button 😄 * fixed bug that alows you to have month be 0 * fixed linting and bug where month/day could be 0 * Update application.py changd inputs to tk.Text from tk.Entry and resized the entry boxes also when you create a event is updates the list * Update application.py added the start of horrible looks and the hatrid * updated __main__ and app.py this one is anoying all black, text is near black to click you have to hold left click when clicking a button a popup will apear press enter then let go of left click on the let go the button will click also closing the app may be hard * added more hatrid * removed random import * fixed linting issue * fix for no lowercase in entrys
This reverts commit fd2036c.
User login created. Not yet linked to main application.
* Update application.py added more indepth date checking and addedback button 😄 * fixed bug that alows you to have month be 0 * fixed linting and bug where month/day could be 0 * Update application.py changd inputs to tk.Text from tk.Entry and resized the entry boxes also when you create a event is updates the list * Update application.py added the start of horrible looks and the hatrid * updated __main__ and app.py this one is anoying all black, text is near black to click you have to hold left click when clicking a button a popup will apear press enter then let go of left click on the let go the button will click also closing the app may be hard * added more hatrid * removed random import * fixed linting issue * fix for no lowercase in entrys * half finsihed but have to go try finished this
Updated and moved aspects of code.
Updated dark mode update method.
lemonsaurus
reviewed
Mar 5, 2019
| ttl, jsonMessages["escapeFour"])): | ||
| if (messagebox.askyesno( | ||
| ttl, jsonMessages["escapeFive"])): | ||
| pass |
Member
There was a problem hiding this comment.
this makes me very dizzy. you should try to avoid this kind of deep nesting.
| Create the applications pages. | ||
|
|
||
| Arguments: | ||
| N/A |
Member
There was a problem hiding this comment.
pointless thing to include in the docstring.
| self.cursor.execute('''INSERT INTO events(name,userid,location, | ||
| date,description) | ||
| VALUES(?,?,?,?,?)''', (name, | ||
| userID, |
Member
There was a problem hiding this comment.
This is an incredibly weird way to format this.
Member
|
Nice overview in the README, and a fun idea for an app. Looking forward to testing it out. As for the code itself, it's mostly competent but the readability is poor. Highly inconsistent code style with stuff like indentation, brace styles, docstrings, variable naming.. Some shadowing of built-ins and weird choice of data structures (like dicts where a simple tuple would be fine). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.