Skip to content

geometry: clean up imOut if operation fails #9785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akx wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −24
Open

geometry: clean up imOut if operation fails #9785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85da8f6
geometry: clean up imOut if operation fails
akx Jul 9, 2026
cca1c22
Update src/_imaging.c
akx Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 34 additions & 24 deletions src/_imaging.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2187,30 +2187,40 @@ _transpose(ImagingObject *self, PyObject *args) {
return NULL;
}

if (imOut) {
switch (op) {
case 0:
(void)ImagingFlipLeftRight(imOut, imIn);
break;
case 1:
(void)ImagingFlipTopBottom(imOut, imIn);
break;
case 2:
(void)ImagingRotate90(imOut, imIn);
break;
case 3:
(void)ImagingRotate180(imOut, imIn);
break;
case 4:
(void)ImagingRotate270(imOut, imIn);
break;
case 5:
(void)ImagingTranspose(imOut, imIn);
break;
case 6:
(void)ImagingTransverse(imOut, imIn);
break;
}
if (!imOut) {
return NULL;
}

Imaging imTemp = NULL; // will be either NULL or imOut after the operation finishes
switch (op) {
case 0:
imTemp = ImagingFlipLeftRight(imOut, imIn);
break;
case 1:
imTemp = ImagingFlipTopBottom(imOut, imIn);
break;
case 2:
imTemp = ImagingRotate90(imOut, imIn);
break;
case 3:
imTemp = ImagingRotate180(imOut, imIn);
break;
case 4:
imTemp = ImagingRotate270(imOut, imIn);
break;
case 5:
imTemp = ImagingTranspose(imOut, imIn);
break;
case 6:
imTemp = ImagingTransverse(imOut, imIn);
break;
default:
PyErr_SetString(PyExc_ValueError, "No such transpose operation");
return NULL;
}
if (!imTemp) { // operation failed and will have set an exception
ImagingDelete(imOut);
return NULL;
}

return PyImagingNew(imOut);
Expand Down
Loading