Repository navigation
fix: resolve the venv path so entrypoint shebangs are absolute - #171
Open
akashchamp wants to merge 1 commit into
Open
akashchamp wants to merge 1 commit into
akashchamp wants to merge 1 commit into
Conversation
A relative path passed to `poetry bundle venv` ended up in the shebangs of the bundled entrypoints, so they only worked from the original directory.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the
pathargument ofpoetry bundle venvbefore handing it to the bundler. With a relative path (e.g.../bundle) the generated entrypoints got a relative shebang (#!../bundle/bin/python) and failed with "bad interpreter" when run from any other directory.Resolves #97
Verified with a small project that has a console script: before the change
poetry bundle venv ../outwrote#!../out/bin/pythonand running./out/bin/demofrom the parent directory failed; after it the shebang is#!/tmp/mv/out/bin/pythonand the script runs. Added a console test that fails without the change; ruff check/format and mypy are clean. I did not add a changelog entry since the file has no unreleased section.