Repository navigation
Conversation
…ings and card brands (220 tests) Add logic to make the 'validators' package importable from various locations.
…ings and card brands (220 tests)
…ings and card brands (220 tests)
…ings and card brands (220 tests)
…ings and card brands (220 tests)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validators covered here are the ones whose existing tests are thinnest — length, between, uuid, mac_address, iban, cron — plus the encoding and card-brand matrices the current suite only samples. This adds 220 tests in four files under tests/, following the repo's own parametrized style, plus a small conftest so the suite also runs without an install. No production code changed. A few quirks found while probing are pinned as-is with a comment, like uuid accepting any version and brace/URN spellings despite the 'UUID-v4' docstring, and AbsMax() >= AbsMax() being True while AbsMax() == AbsMax() is False.
Checked locally: the four new files pass (220 passed). The full upstream suite has 28 pre-existing failures, all in the crypto-address tests because the optional eth extra isn't installed here — they fail identically without this PR.