Skip to content

Accept lowercase prefixes in Spanish NIE validation #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aminark wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −1
Open

Accept lowercase prefixes in Spanish NIE validation #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45e9a6a
Accept lowercase prefixes in Spanish NIE validation
Aminark Oct 25, 2026
4082eb9
Test lowercase NIE prefixes and checksum rejection
Aminark Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/validators/i18n/es.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def es_nie(value: str, /):
"""
number_by_letter = {"X": "0", "Y": "1", "Z": "2"}
# NIE must must start with X Y or Z
if value and value[0] in number_by_letter:
if value and value[0].upper() in number_by_letter:
return _nif_nie_validation(value, number_by_letter)
return False

Expand Down
15 changes: 15 additions & 0 deletions tests/i18n/test_es.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,21 @@ def test_returns_true_on_valid_nie(value: str):
assert es_nie(value)


@pytest.mark.parametrize("validate", [es_nie, es_doi])
@pytest.mark.parametrize("value", ["X0095892M", "Y2584969J", "Z2915723H"])
def test_nie_accepts_lowercase_prefix(validate: Callable[[str], object], value: str):
"""Accept lowercase NIE prefixes consistently with NIF and CIF letters."""
assert validate(value[0].lower() + value[1:]) is True
assert validate(value.lower()) is True


@pytest.mark.parametrize("validate", [es_nie, es_doi])
@pytest.mark.parametrize("value", ["x0095892x", "y2584969x", "z2915723x"])
def test_lowercase_nie_still_checks_checksum(validate: Callable[[str], object], value: str):
"""Do not accept an invalid checksum after normalizing the prefix."""
assert isinstance(validate(value), ValidationError)


@pytest.mark.parametrize(
("value",),
[
Expand Down