refactor: pass version to more hooks#945
Open
tiran wants to merge 1 commit intopython-wheel-build:mainfrom
Open
refactor: pass version to more hooks#945tiran wants to merge 1 commit intopython-wheel-build:mainfrom
tiran wants to merge 1 commit intopython-wheel-build:mainfrom
Conversation
Pass the resolved version to more methods and hooks. This gives
`packagesettings.get_extra_environ` access to version information in
most cases.
`dependencies.get_build_*_dependencies` hooks now have access to version
in most cases. Nightly builds from VCS don't have the version. Nightly
builds have to prepare an environment, then request package metadata to
get the version from metadata.
The improvement will enable us to add the version as a template
variable, so `env` in package settings can use something like
`${__version__}` in the future.
Signed-off-by: Christian Heimes <cheimes@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the resolved version to more methods and hooks. This gives
packagesettings.get_extra_environaccess to version information in most cases.dependencies.get_build_*_dependencieshooks now have access to version in most cases. Nightly builds from VCS don't have the version. Nightly builds have to prepare an environment, then request package metadata to get the version from metadata.The improvement will enable us to add the version as a template variable, so
envin package settings can use something like${__version__}in the future.See: #946