Skip to content

Fix diagram in README.md#664

Merged
hugovk merged 4 commits into
mainfrom
unknown repository
May 25, 2025
Merged

Fix diagram in README.md#664
hugovk merged 4 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented May 18, 2025

Copy link
Copy Markdown
  • Fix line breaks (\n is not supported)
  • Fix arrow colors

@codecov

codecov Bot commented May 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b607ac) to head (0eb91c5).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #664   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         2149      2149           
  Branches        97        97           
=========================================
  Hits          2149      2149           
Flag Coverage Δ
Python_3.10.17 100.00% <ø> (ø)
Python_3.11.12 100.00% <ø> (ø)
Python_3.12.10 100.00% <ø> (ø)
Python_3.13.3 100.00% <ø> (ø)
Python_3.14.0-alpha.7 ?
Python_3.14.0-beta.1 100.00% <ø> (?)
Python_3.9.22 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugovk

hugovk commented May 18, 2025

Copy link
Copy Markdown
Member

Thanks!

Before:

image

After:

image

The line from "Published PR" to "Awaiting core review" should be green for core dev.

@ghost

ghost commented May 18, 2025

Copy link
Copy Markdown
Author

The line from "Published PR" to "Awaiting core review" should be green for core dev.

Thanks. I fixed it.

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread README.md Outdated
Comment on lines +51 to +52
B & C -- new review by<br/>another contributor --> C
C & B & E -- new core review<br/>requests changes --> D[Awaiting changes]:::creator

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does <br> (without /) work too?

I'm pretty sure that \ns used to work, I wonder if they changed it in a recent update.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use <br> then :)

@hugovk hugovk merged commit 7d11fdf into python:main May 25, 2025
10 checks passed
@ezio-melotti

Copy link
Copy Markdown
Member

Thanks for catching and fixing this!

@ghost ghost deleted the patch-1 branch May 25, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants