Give concurrent.future.Future the right module name - #115386
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
|
There is nothing stale about it - it just needs a reviewer. It is a fairly trivial change. |
|
This PR is stale because it has been open for 90 days with no activity. |
|
Currently there are more classes in this file, eg. |
f34ab06 to
7bb8f18
Compare
7bb8f18 to
028c70d
Compare
|
Hi, please avoid force push in the future, see: https://devguide.python.org/getting-started/pull-request-lifecycle/#don-t-force-push |
Thanks for letting me know. In this case, I thought the change was relevant to embed into a single commit (and it needed rebasing anyway), but I will be sure to not do this in the future. |
Currently the classes in
concurrent.futuresgive unexpected/internal sub-package names for__str__of the class:After this change, they get the intended (and documented) location.
This is an aesthetic change to make it easier to correlate an object with its documentation, and does cause a noteworthy issue beyond that.
I did not include the executor implementations in this change as they are implemented in a non-private module. However, the documentation does state that they come from
concurrent.futures:I did some research, and there are a few occurrences in the CPython implementation of re-defining
__module__in this way (examples include re, abc, and io).