Skip to content

gh-115810: Expose name attribute of datetime.timezone - #131210

Merged
StanFromIreland merged 4 commits into
python:mainfrom
StanFromIreland:tz-name
Oct 23, 2026
Merged

gh-115810: Expose name attribute of datetime.timezone#131210
StanFromIreland merged 4 commits into
python:mainfrom
StanFromIreland:tz-name

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Mar 13, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Pretty sure the C implementation is right, but it definitely needs a good review to be sure.

📚 Documentation preview 📚: https://cpython-previews--131210.org.readthedocs.build/

@bedevere-app bedevere-app Bot mentioned this pull request Mar 13, 2025
Closed
@StanFromIreland

StanFromIreland commented Apr 25, 2025

Copy link
Copy Markdown
Member Author

Maybe @pganssle you could review?

encukou
encukou reviewed Feb 4, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-03-13-20-21-00.gh-issue-115810.qwrb231.rst Outdated
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 22, 2026
@StanFromIreland
StanFromIreland marked this pull request as draft August 24, 2026 16:54
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 28, 2026
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Oct 23, 2026
@StanFromIreland
StanFromIreland marked this pull request as ready for review October 23, 2026 18:14
@read-the-docs-community

read-the-docs-community Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35362443 | 📁 Comparing f278520 against main (8d11920)

  🔍 Preview build  

11 files changed · ± 11 modified

± Modified

pganssle
pganssle requested changes Oct 23, 2026
View reviewed changes
Comment thread Lib/test/datetimetester.py Outdated
@bedevere-app

bedevere-app Bot commented Oct 23, 2026

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@StanFromIreland

StanFromIreland commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented Oct 23, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from pganssle October 23, 2026 18:33
@StanFromIreland
StanFromIreland merged commit b341b81 into python:main Oct 23, 2026
61 of 64 checks passed
@StanFromIreland
StanFromIreland deleted the tz-name branch October 23, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@pganssle pganssle pganssle approved these changes
@abalkin abalkin Awaiting requested review from abalkin
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @encukou @pganssle