Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 5, 2025

No description provided.

@pablogsal
Copy link
Member

Maybe is time to put a linter for this in CI

@vstinner vstinner enabled auto-merge (squash) December 6, 2025 11:10
@vstinner vstinner merged commit d119443 into python:main Dec 6, 2025
89 of 91 checks passed
@vstinner vstinner deleted the remove_unused_imports branch December 6, 2025 11:27
@vstinner
Copy link
Member Author

vstinner commented Dec 6, 2025

Maybe is time to put a linter for this in CI

It would require to annotate many "unused" imports which should be kept with # noqa: F401. Some people don't like this. But yeah, it sounds like a good idea :-)

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Clang Installed 3.x (tier-3) has failed when building commit d119443.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1645/builds/1679) and take a look at the build logs.
  4. Check if the failure is related to this commit (d119443) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1645/builds/1679

Failed tests:

  • test_profiling

Failed subtests:

  • test_sampling_with_collapsed_export - test.test_profiling.test_sampling_profiler.test_integration.TestSampleProfilerIntegration.test_sampling_with_collapsed_export

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/test/test_profiling/test_sampling_profiler/test_integration.py", line 488, in test_sampling_with_collapsed_export
    profiling.sampling.sample.sample(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        subproc.process.pid,
        ^^^^^^^^^^^^^^^^^^^^
        collector,
        ^^^^^^^^^^
        duration_sec=1,
        ^^^^^^^^^^^^^^^
    )
    ^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/profiling/sampling/sample.py", line 224, in sample
    profiler = SampleProfiler(
        pid,
    ...<5 lines>...
        skip_non_matching_threads=skip_non_matching_threads
    )
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/profiling/sampling/sample.py", line 36, in __init__
    self.unwinder = _remote_debugging.RemoteUnwinder(
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.pid, all_threads=self.all_threads, mode=mode, native=native, gc=gc,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        skip_non_matching_threads=skip_non_matching_threads
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
RuntimeError: Failed to find the PyRuntime section in process 91942 on Linux platform


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/test/test_profiling/test_sampling_profiler/test_integration.py", line 488, in test_sampling_with_collapsed_export
    profiling.sampling.sample.sample(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        subproc.process.pid,
        ^^^^^^^^^^^^^^^^^^^^
        collector,
        ^^^^^^^^^^
        duration_sec=1,
        ^^^^^^^^^^^^^^^
    )
    ^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/profiling/sampling/sample.py", line 224, in sample
    profiler = SampleProfiler(
        pid,
    ...<5 lines>...
        skip_non_matching_threads=skip_non_matching_threads
    )
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/profiling/sampling/sample.py", line 36, in __init__
    self.unwinder = _remote_debugging.RemoteUnwinder(
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.pid, all_threads=self.all_threads, mode=mode, native=native, gc=gc,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        skip_non_matching_threads=skip_non_matching_threads
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
RuntimeError: Failed to find the PyRuntime section in process 86184 on Linux platform

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants