Skip to content

gh-64551: Add RFC 5034 AUTH support to poplib #142613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fatelei wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-64551: Add RFC 5034 AUTH support to poplib #142613

fatelei wants to merge 6 commits into from
+182 −3

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 12, 2025 •
edited by github-actions bot
Loading

Add RFC 5034 AUTH support to poplib

📚 Documentation preview 📚: https://cpython-previews--142613.org.readthedocs.build/

@fatelei fatelei requested a review from a team as a code owner December 12, 2025 07:10
@bedevere-app bedevere-app bot mentioned this pull request Dec 12, 2025
Open
@diegorusso
Copy link
Contributor

diegorusso commented Dec 12, 2025

Can you please rebase/merge your branch on top of main please?

@fatelei
Copy link
Contributor Author

fatelei commented Dec 12, 2025

Can you please rebase/merge your branch on top of main please?

done

@diegorusso
Copy link
Contributor

diegorusso commented Dec 12, 2025

Can you please rebase/merge your branch on top of main please?

done

Thanks! I removed all the reviewers and added only the ones in the original issue.

aisk
aisk reviewed Dec 12, 2025
View reviewed changes
@picnixz picnixz self-requested a review December 12, 2025 13:12
bitdancer
bitdancer requested changes Dec 24, 2025
View reviewed changes
Copy link
Member

@bitdancer bitdancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I have several suggestions, mostly about mimicing the smtplib API for consistency.

@bedevere-app
Copy link

bedevere-app bot commented Dec 24, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aisk
Copy link
Contributor

aisk commented Dec 25, 2025

Hi, please avoid of force push in the future, see: https://devguide.python.org/getting-started/pull-request-lifecycle/#don-t-force-push

@fatelei
Copy link
Contributor Author

fatelei commented Dec 25, 2025 •
edited
Loading

Hi, please avoid of force push in the future, see: https://devguide.python.org/getting-started/pull-request-lifecycle/#don-t-force-push

i rebase, but i can not push, so i force push, sorry

@aisk
Copy link
Contributor

aisk commented Dec 25, 2025

i rebase, but i can not push, so i force push, sorry

You can fetch the remote, then use git merge ... to merge the changes into your local branch, make further changes, and finally git push ... to the remote safely and without -f option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments

@bitdancer bitdancer bitdancer requested changes

@warsaw warsaw Awaiting requested review from warsaw

@picnixz picnixz Awaiting requested review from picnixz

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fatelei @diegorusso @aisk @bitdancer