Skip to content

gh-140009: Improve performance of datetime extension module by using PyTuple_FromArray #144532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
taegyunkim wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −7
Draft

gh-140009: Improve performance of datetime extension module by using PyTuple_FromArray #144532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f9cba2
Replace datetimemodule PyTuple_Pack uses with PyTuple_FromArray
taegyunkim Feb 5, 2026
15a8987
Add news entry for the change
taegyunkim Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-02-05-17-59-01.gh-issue-140009.bYXcvi.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve performance of datetime extension module. Patch by Taegyun Kim.
14 changes: 7 additions & 7 deletions Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2692,7 +2692,7 @@ delta_divmod(PyObject *left, PyObject *right)
Py_DECREF(divmod);
return NULL;
}
result = PyTuple_Pack(2, PyTuple_GET_ITEM(divmod, 0), delta);
result = PyTuple_FromArray((PyObject*[]){ PyTuple_GET_ITEM(divmod, 0), delta }, 2);
Py_DECREF(delta);
Py_DECREF(divmod);
return result;
Expand Down Expand Up @@ -4478,8 +4478,8 @@ timezone_getinitargs(PyObject *op, PyObject *Py_UNUSED(dummy))
{
PyDateTime_TimeZone *self = PyTimeZone_CAST(op);
if (self->name == NULL)
return PyTuple_Pack(1, self->offset);
return PyTuple_Pack(2, self->offset, self->name);
return PyTuple_FromArray((PyObject*[]){ self->offset }, 1);
return PyTuple_FromArray((PyObject*[]){ self->offset, self->name }, 2);
}

static PyMethodDef timezone_methods[] = {
Expand Down Expand Up @@ -5228,9 +5228,9 @@ time_getstate(PyDateTime_Time *self, int proto)
/* Set the first bit of the first byte */
PyBytes_AS_STRING(basestate)[0] |= (1 << 7);
if (! HASTZINFO(self) || self->tzinfo == Py_None)
result = PyTuple_Pack(1, basestate);
result = PyTuple_FromArray((PyObject*[]){ basestate }, 1);
else
result = PyTuple_Pack(2, basestate, self->tzinfo);
result = PyTuple_FromArray((PyObject*[]){ basestate, self->tzinfo }, 2);
Py_DECREF(basestate);
}
return result;
Expand Down Expand Up @@ -7150,9 +7150,9 @@ datetime_getstate(PyDateTime_DateTime *self, int proto)
/* Set the first bit of the third byte */
PyBytes_AS_STRING(basestate)[2] |= (1 << 7);
if (! HASTZINFO(self) || self->tzinfo == Py_None)
result = PyTuple_Pack(1, basestate);
result = PyTuple_FromArray((PyObject*[]){ basestate }, 1);
else
result = PyTuple_Pack(2, basestate, self->tzinfo);
result = PyTuple_FromArray((PyObject*[]){ basestate, self->tzinfo }, 2);
Py_DECREF(basestate);
}
return result;
Expand Down
Loading