gh-149981: Test lazy import corner cases with module-level __getattr__#149982
Open
sobolevn wants to merge 1 commit into
Open
gh-149981: Test lazy import corner cases with module-level __getattr__#149982sobolevn wants to merge 1 commit into
__getattr__#149982sobolevn wants to merge 1 commit into
Conversation
DinoV
approved these changes
May 18, 2026
Contributor
DinoV
left a comment
There was a problem hiding this comment.
I kind of feel like the warning case is unnecessary - really it's just making sure the code is running as nothing special happens w/ warnings at the boundary. But I don't have a strong objection to it.
Member
Author
|
I think that warnings are special and common enough to have a separate test case for them :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__getattr__#149981